Skip to content

[release] use semantic versioning format #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2019
Merged

[release] use semantic versioning format #692

merged 4 commits into from
Mar 25, 2019

Conversation

Saviq
Copy link
Collaborator

@Saviq Saviq commented Mar 21, 2019

Adhere to https://semver.org/, using the latest tag, number of commits since
latest annotated tag and commit abbreviation as version, pre-release
identifier and build metadata, respectively.

@Saviq Saviq requested review from gerboland and ricab March 21, 2019 18:03
@Saviq
Copy link
Collaborator Author

Saviq commented Mar 21, 2019 •
edited
Loading

You can see the -dev version generated in travis:

# snap:
-- Setting version to: v0.6.0-dev.212+g7e784c4
…
Snapped multipass_v0.6.0-dev.212+g7e784c4_amd64.snap
# macOS:
-- Setting version to: v0.6.0-dev.238+g2e065e4

To check that it works on release, use:

git tag -as v0.6.0 - just remember to remove it then with git tag -d v0.6.0.

@Saviq Saviq added the no-merge label Mar 21, 2019
@Saviq Saviq removed the no-merge label Mar 21, 2019
ricab
ricab approved these changes Mar 22, 2019
View reviewed changes
Copy link
Collaborator

@ricab ricab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

To follow up on my concern yesterday, the spec dispels it:

[...] A pre-release version indicates that the version is unstable and might not satisfy the intended compatibility requirements as denoted by its associated normal version

bors r+

bors bot added a commit that referenced this pull request Mar 22, 2019
@bors @Saviq
Merge #692
e453442 
692: [release] use semantic versioning format r=ricab a=Saviq

Adhere to https://semver.org/, using the latest tag, number of commits since
latest annotated tag and commit abbreviation as version, pre-release
identifier and build metadata, respectively.

Co-authored-by: Michał Sawicz <michal@sawicz.net>
@ricab
Copy link
Collaborator

ricab commented Mar 22, 2019

Oops, another review pending...

bors r-

@bors
Copy link
Contributor

bors bot commented Mar 22, 2019

Canceled

gerboland
gerboland approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@gerboland gerboland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
bors r+

bors bot added a commit that referenced this pull request Mar 22, 2019
@bors @Saviq
Merge #692
b1b0a77 
692: [release] use semantic versioning format r=gerboland a=Saviq

Adhere to https://semver.org/, using the latest tag, number of commits since
latest annotated tag and commit abbreviation as version, pre-release
identifier and build metadata, respectively.

Co-authored-by: Michał Sawicz <michal@sawicz.net>
@Saviq
Copy link
Collaborator Author

Saviq commented Mar 22, 2019

bors r-

@bors
Copy link
Contributor

bors bot commented Mar 22, 2019

Canceled

gerboland
gerboland approved these changes Mar 22, 2019
View reviewed changes
Copy link
Contributor

@gerboland gerboland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep
bors r+

bors bot added a commit that referenced this pull request Mar 22, 2019
@bors @Saviq
Merge #692
8e4336d 
692: [release] use semantic versioning format r=gerboland a=Saviq

Adhere to https://semver.org/, using the latest tag, number of commits since
latest annotated tag and commit abbreviation as version, pre-release
identifier and build metadata, respectively.

Co-authored-by: Michał Sawicz <michal@sawicz.net>
@Saviq
Copy link
Collaborator Author

Saviq commented Mar 22, 2019

For posterity:

# macOS
-- Setting version to: 0.6.0-dev.238+g5c642f4
# snap
-- Setting version to: 0.6.0-dev.212+gfd9fd47
…
Snapped multipass_0.6.0-dev.212+gfd9fd47_amd64.snap

@bors
Copy link
Contributor

bors bot commented Mar 22, 2019

Build failed

@Saviq Saviq force-pushed the apply-semver branch 5 times, most recently from 4122d7f to cfba1fe Compare March 25, 2019 07:41
Saviq added 2 commits March 25, 2019 09:00
@Saviq
[cmake] use semantic versioning format
8450c7c 
Adhere to https://semver.org/, using the latest tag, number of commits since
latest annotated tag and commit abbreviation as version, pre-release
identifier and build metadata, respectively.
@Saviq
[snap] get Multipass version from CMake
52965e5
@Saviq
[cmake] don't rely on CMake CACHE
29443f1 
Apparently that messes with the build config.
@Saviq
Copy link
Collaborator Author

Saviq commented Mar 25, 2019

bors r=greyback,ricab

bors bot added a commit that referenced this pull request Mar 25, 2019
@bors @Saviq
Merge #692
43ccf57 
692: [release] use semantic versioning format r=greyback,ricab a=Saviq

Adhere to https://semver.org/, using the latest tag, number of commits since
latest annotated tag and commit abbreviation as version, pre-release
identifier and build metadata, respectively.

Co-authored-by: Michał Sawicz <michal@sawicz.net>
@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #692 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #692   +/-   ##
=======================================
  Coverage   66.59%   66.59%           
=======================================
  Files         168      168           
  Lines        5943     5943           
=======================================
  Hits         3958     3958           
  Misses       1985     1985

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe05e95...29443f1. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Mar 25, 2019 •
edited
Loading

Codecov Report

Merging #692 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #692   +/-   ##
=======================================
  Coverage   66.59%   66.59%           
=======================================
  Files         168      168           
  Lines        5943     5943           
=======================================
  Hits         3958     3958           
  Misses       1985     1985

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe05e95...29443f1. Read the comment docs.

@bors
Copy link
Contributor

bors bot commented Mar 25, 2019

Build succeeded

@bors bors bot merged commit 29443f1 into master Mar 25, 2019
@bors bors bot deleted the apply-semver branch March 25, 2019 14:47
ricab pushed a commit that referenced this pull request May 8, 2025
@georgeliao
Merge pull request #692 from canonical/force-stop-daemon
ca40567 
[windows] Force stop daemon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricab ricab ricab approved these changes

+1 more reviewer

@gerboland gerboland gerboland approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Saviq @ricab @gerboland