Improve cli client tests #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow testing that client calls trigger expected RPC requests. Using a strict mock, to fail on unexpected calls. This currently makes client tests fail.
Use "fails" to follow convention used by the other tests and easily identify test type.
Covers list, start, stop, restart, and suspend calls.
|
Seems legit. bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 21, 2019
691: Improve cli client tests r=Saviq a=ricab This prepares the ground for the testing the pet-env feature in the CLI client. It improves CLI client tests, by checking - the expected RPC calls are triggered - no unexpected RPC calls are triggered A future step is to check that the request parameters correspond to expectations. Co-authored-by: Ricardo Abreu <ricab@ricabhome.org>
Build failed |
|
Sorry, didn't realize this was going into |
|
No worries, just changed base to master since the other one was merged anyway. |
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
=======================================
Coverage 66.59% 66.59%
=======================================
Files 168 168
Lines 5943 5943
=======================================
Hits 3958 3958
Misses 1985 1985Continue to review full report at Codecov.
|
|
bors r+ This conflicts on Mac, will take car of that in a moment. |
bors bot
added a commit
that referenced
this pull request
Mar 21, 2019
691: Improve cli client tests r=Saviq a=ricab This prepares the ground for the testing the pet-env feature in the CLI client. It improves CLI client tests, by checking - the expected RPC calls are triggered - no unexpected RPC calls are triggered A future step is to check that the request parameters correspond to expectations. Co-authored-by: Ricardo Abreu <ricab@ricabhome.org>
|
Thanks @Saviq. Is there a way to see the conflict in travis? Or have to try locally? |
|
@ricab not at the moment, it's a trivial one though. |
Build failed |
ricab
added a commit
that referenced
this pull request
May 8, 2025
Fix symlink resolution when mounting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prepares the ground for the testing the pet-env feature in the CLI client. It improves CLI client tests, by checking
A future step is to check that the request parameters correspond to expectations.