Extract instance creation from launch and provide it over RPC #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Place instance creation in a separate method that is called when launching, in preparation for an RPC create operation.
Add a `create` "lane" to the RPC protocol, reusing `launch` messages.
Moves instance name derivation and starting into (existing) auxiliary method, to facilitate merging changes in master.
Extend the original client with a basic `create` command, to use in daemon tests. Implement the skeleton of said command, with the goal of using it as the test interface to the corresponding RPC method. Test whether `create` is called (still failing).
Fills in overridden `run` method in TestCreate command. Fixes corresponding request and reply types.
Makes failing test pass.
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
- Coverage 66.39% 66.34% -0.05%
==========================================
Files 165 166 +1
Lines 5912 5927 +15
==========================================
+ Hits 3925 3932 +7
- Misses 1987 1995 +8
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #676 +/- ##
==========================================
- Coverage 66.64% 66.59% -0.06%
==========================================
Files 167 168 +1
Lines 5928 5943 +15
==========================================
+ Hits 3951 3958 +7
- Misses 1977 1985 +8
Continue to review full report at Codecov.
|
gerboland
reviewed
Mar 19, 2019
Build failed |
|
Sorry, got confused with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reissue of #663
This can be merged presently. Client side to come separately.