Skip to content

Extract instance creation from launch #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 14 commits into from
Closed

Extract instance creation from launch #663

wants to merge 14 commits into from

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented Mar 5, 2019

Place instance creation in a separate method, to prepare the way to create without launching.

@ricab ricab force-pushed the pet-env-extract-create branch 2 times, most recently from 65dcc19 to de74fa2 Compare March 5, 2019 19:10
@Saviq
Copy link
Collaborator

Saviq commented Mar 7, 2019 •
edited
Loading

So a draft PR doesn't run checks, wonder if bors will act on it though?

bors try

bors bot added a commit that referenced this pull request Mar 7, 2019
@bors
Try #663:
cf90ab1
@Saviq
Copy link
Collaborator

Saviq commented Mar 7, 2019 •
edited
Loading

So bors does work, travis ignores it altogether though. Even explicit "Re-run all checks" on the Checks page is ignored.

@bors
Copy link
Contributor

bors bot commented Mar 7, 2019

try

Build failed

@Saviq
Copy link
Collaborator

Saviq commented Mar 7, 2019

FWIW, this failed b/c is a PR into pet-env, not master, and it lacks the latest commits from there.

@ricab
Copy link
Collaborator Author

ricab commented Mar 7, 2019

Thanks @Saviq. Yeah I haven't rebased this on master after the PR that fixes the failing test.

@ricab
Copy link
Collaborator Author

ricab commented Mar 7, 2019 •
edited
Loading

Here something discussing absent Travis CI in draft PRs: https://travis-ci.community/t/draft-pull-requests-not-being-built/2434/5

This is still quite new and I suppose they will give some option to enable it. Meanwhile, manual bors works too

ricab added 3 commits March 7, 2019 12:35
@ricab
Extract instance creation from launch
5fb86d5 
Place instance creation in a separate method that is called when launching, in preparation for an RPC create operation.
@ricab
Add create to the RPC protocol
a4d1118 
Add a `create` "lane" to the RPC protocol, reusing `launch` messages.
@ricab
Rename and move function auxiliary functions
d3af9cd
@ricab ricab force-pushed the pet-env-extract-create branch from de74fa2 to a4d1118 Compare March 7, 2019 12:39
@ricab
Copy link
Collaborator Author

ricab commented Mar 7, 2019

bors try

bors bot added a commit that referenced this pull request Mar 7, 2019
@bors
Try #663:
ef6bb4c
@ricab
Copy link
Collaborator Author

ricab commented Mar 7, 2019

bors try-

@ricab ricab changed the base branch from pet-env to master March 7, 2019 12:50
@ricab
Copy link
Collaborator Author

ricab commented Mar 7, 2019

Just changed base back to master, to avoid having to manually rebase.

bors try

bors bot added a commit that referenced this pull request Mar 7, 2019
@bors
Try #663:
760418d
@bors
Copy link
Contributor

bors bot commented Mar 7, 2019

try

Build succeeded

ricab added 10 commits March 11, 2019 16:38
@ricab
Reorganize launch/create - prep for upstream
3ad043c 
Moves instance name derivation and starting into (existing) auxiliary method, to facilitate merging changes in master.
@ricab
Merge branch 'master' into pet-env-extract-create-try-merge-master
5042be8
@ricab
Rename launch tests to prepare for create tests
7fd8af0
@ricab
Add scaffolding to test create RPC
58fd7b7 
Extend the original client with a basic `create` command, to use in daemon tests. Implement the skeleton of said command, with the goal of using it as the test interface to the corresponding RPC method. Test whether `create` is called (still failing).
@ricab
Call create RPC in TestCreate
a8d169a 
Fills in overridden `run` method in TestCreate command. Fixes corresponding request and reply types.
@ricab
Reorder test command code
d787155
@ricab
Replicate some launch tests for create (one of them still failing).
1b8bd33
@ricab
Output streamed replies to test_create
c763add 
Makes failing test pass.
@ricab
Replicate remaining launch tests on create RPC
4e5551d
@ricab
Parameterize create/launch (daemon) tests
8c09a5b
@ricab ricab force-pushed the pet-env-extract-create branch from f60cd7f to fcdd90c Compare March 12, 2019 12:12
@ricab
Copy link
Collaborator Author

ricab commented Mar 12, 2019

bors try

bors bot added a commit that referenced this pull request Mar 12, 2019
@bors
Try #663:
b787474
@bors
Copy link
Contributor

bors bot commented Mar 12, 2019

try

Build failed

@ricab
Copy link
Collaborator Author

ricab commented Mar 12, 2019

bors try

bors bot added a commit that referenced this pull request Mar 12, 2019
@bors
Try #663:
4619a3f
@bors
Copy link
Contributor

bors bot commented Mar 12, 2019

try

Build failed

@ricab ricab marked this pull request as ready for review March 12, 2019 15:41
@ricab ricab marked this pull request as ready for review March 12, 2019 15:42
@ricab
Copy link
Collaborator Author

ricab commented Mar 12, 2019

This "draft" feature does not seem to be working very well yet. In particular, it is not showing checks even after turning it into a PR. So closing and opening a new one.

@ricab ricab closed this Mar 12, 2019
@ricab ricab mentioned this pull request Mar 12, 2019
Merged
bors bot added a commit that referenced this pull request Mar 21, 2019
@bors @ricab
Merge #676
e33e4a6 
676: Extract instance creation from launch and provide it over RPC r=gerboland a=ricab

Reissue of #663 

This can be merged presently. Client side to come separately.

Co-authored-by: Ricardo Abreu <ricab@ricabhome.org>
ricab pushed a commit that referenced this pull request May 8, 2025
@sharder996
Merge pull request #663 from canonical/update-actions-cancel-behavior
efda81e 
[ci] Update all GHA to only cancel for merge queues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricab @Saviq