Skip to content

Conversation

ricab
Copy link
Collaborator

@ricab ricab commented Apr 15, 2025

Reverts #3993

@ricab ricab force-pushed the revert-3993-skip-linux-ci-on-unrelated branch from f16fbf8 to 4a35478 Compare April 15, 2025 16:12
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.53%. Comparing base (896fcb7) to head (4a35478).
Report is 3421 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4047   +/-   ##
=======================================
  Coverage   89.53%   89.53%           
=======================================
  Files         260      260           
  Lines       14741    14741           
=======================================
  Hits        13198    13198           
  Misses       1543     1543           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ricab ricab marked this pull request as ready for review April 15, 2025 17:24
@ricab ricab mentioned this pull request Apr 17, 2025
@ricab ricab requested a review from sharder996 April 17, 2025 11:06
@ricab ricab marked this pull request as draft April 17, 2025 11:16
@ricab ricab marked this pull request as ready for review April 17, 2025 11:16
@ricab ricab removed the request for review from sharder996 April 17, 2025 11:23
Copy link
Member

@xmkg xmkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we know why the change causes a problem?

@ricab
Copy link
Collaborator Author

ricab commented Apr 17, 2025

Yes, we have branch protections requiring those builds to succeed before we can merge, and apparently that applies to builds triggered by pull_request and not just merge_group. Furthermore, I think the filters are somehow applied to merge_group triggers as well.

We'll need #4042 instead, but I'd like the CI merger to land first.

Copy link
Collaborator

@sharder996 sharder996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding my review as well! LGTM

@ricab ricab added this pull request to the merge queue Apr 17, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 17, 2025
@xmkg xmkg added this pull request to the merge queue Apr 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 18, 2025
@ricab ricab added this pull request to the merge queue Apr 21, 2025
@ricab ricab removed this pull request from the merge queue due to a manual request Apr 21, 2025
@ricab ricab merged commit 0dbab50 into main Apr 21, 2025
31 checks passed
@ricab ricab deleted the revert-3993-skip-linux-ci-on-unrelated branch April 21, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants