-
Notifications
You must be signed in to change notification settings - Fork 721
Revert "[ci] Skip Linux CI on unrelated changes" #4047
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f16fbf8
to
4a35478
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4047 +/- ##
=======================================
Coverage 89.53% 89.53%
=======================================
Files 260 260
Lines 14741 14741
=======================================
Hits 13198 13198
Misses 1543 1543 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Do we know why the change causes a problem?
Yes, we have branch protections requiring those builds to succeed before we can merge, and apparently that applies to builds triggered by We'll need #4042 instead, but I'd like the CI merger to land first. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding my review as well! LGTM
Reverts #3993