lxd/instance/qemu: Fix shared storage volume setup during instance migration (from Incus) #15798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems that containers can be copied correctly even with custom volumes attached if the destination server already has volumes with the same name. |
|
@nmezhenskyi hey, please can u book a meeting for us to work through the problem together as the scope of this bug fix remains unclear. Ta |
774fd3a to
550d563
Compare
…ing with an extra disk Signed-off-by: Piotr Resztak <piotr.resztak@futurfusion.io> (cherry picked from commit dbe53f1a152c02adfffd5ee5da71da04a9c6b66d) Signed-off-by: Nikita Mezhenskyi <nikita.mezhenskyi@canonical.com> License: Apache-2.0
…cluster members Fix condition in `MigrateReceive()` and `migrateSendLive()` functions to notify shared storage driver to setup volume on cluster member during instance migration. Signed-off-by: Nikita Mezhenskyi <nikita.mezhenskyi@canonical.com>
550d563 to
37aba12
Compare
tomponline
added a commit
that referenced
this pull request
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15358.
Includes cherry-pick from lxc/incus#1669.
Previously
MigrateReceive()function would incorrectly try callingCreateVolumeFromMigration()for attached local volumes during instance migration and fail with "not supported" error. This change fixes the issue. Now,CreateVolumeFromMigration()is called only for shared storage volumes in order to notify the shared storage driver to setup the volume on the receiving cluster member.