[Backport stable/operate-8.5] ArchUnit rule to support both camelCase and kebab-case in ConditionalOnProperty #37050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
1 task
This ensures that relaxed binding is applied when matching user defined properties to these annotations. The current situation was that only camelCase defined properties would be supported. By using kebab-case explicitly, we support both kebab-case and camelCase.
02ffd81 to
1cea04e
Compare
|
There is no root-level pom in this branch. Rather than adding the ArchUnit test, I've only applied the fix here. I used IntelliJ-IDEA to find all occurrences of in There are no other occurrences of this annotation. The following provides no output: ack ConditionalOnProperty --java --ignore-directory=operate |
|
@mustafadagher Please have a look. Note that this isn't truly a backport any more, at least it's not adding an ArchUnit rule. But it still applies the spirit of the original PR by fixing the bug found by that rule. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #36872 to
stable/operate-8.5.Note that this is not a full backport. It does not copy the ArchUnit rule, but it does apply the associated bug fix.
relates to #36869