Skip to content

fix: do not perform assignee check for m2m clients in Tasklist V1 APIs #37018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 22, 2025
Merged

fix: do not perform assignee check for m2m clients in Tasklist V1 APIs #37018

merged 2 commits into from
Aug 22, 2025

Conversation

ThorbenLindhauer
Copy link
Member

  • fix is to reuse the CamundaAuthentication object
  • the tests are adjusted to actually cover the logic that determines if it's an API user and to not just mock it one way or the other

closes #33185

@ThorbenLindhauer ThorbenLindhauer self-assigned this Aug 20, 2025
@github-actions github-actions bot added the component/tasklist Related to the Tasklist component/team label Aug 20, 2025
@ThorbenLindhauer ThorbenLindhauer force-pushed the 33185-task-v1-complete branch 2 times, most recently from b8e7ce1 to d2b8f85 Compare August 20, 2025 16:49
@ThorbenLindhauer
fix: do not perform assignee check for m2m clients in Tasklist V1 APIs
5ece6f5 
- fix is to reuse the CamundaAuthentication object
- the tests are adjusted to actually cover the logic that determines
  if it's an API user and to not just mock it one way or the other

related to #33185
@ThorbenLindhauer
fix: add case for anonymous user
303429a 
- retains prior semantics, where we treat an anonymous user not as an
  API user

related to #33185
@ThorbenLindhauer ThorbenLindhauer marked this pull request as ready for review August 22, 2025 08:39
kristinkomschow
kristinkomschow approved these changes Aug 22, 2025
View reviewed changes
Copy link
Contributor

@kristinkomschow kristinkomschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Also happy to see less mocking after having fixed a lot of broken mocks recently. :)

@ThorbenLindhauer ThorbenLindhauer added this pull request to the merge queue Aug 22, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2025
@ThorbenLindhauer ThorbenLindhauer added this pull request to the merge queue Aug 22, 2025
@ThorbenLindhauer
Copy link
Member Author

Merge problem was a runner being shut down. Retrying.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2025
@ThorbenLindhauer ThorbenLindhauer added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit ba884b6 Aug 22, 2025
104 of 105 checks passed
@ThorbenLindhauer ThorbenLindhauer deleted the 33185-task-v1-complete branch August 22, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristinkomschow kristinkomschow kristinkomschow approved these changes

Assignees

@ThorbenLindhauer ThorbenLindhauer

Labels
component/tasklist Related to the Tasklist component/team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User tasks cannot be completed through the Tasklist V1 API when authentication with an M2M client.
2 participants
@ThorbenLindhauer @kristinkomschow