Skip to content

Return meaningful error if OIDC provider is unavailable #36912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 19, 2025
Merged

Return meaningful error if OIDC provider is unavailable #36912

merged 3 commits into from
Aug 19, 2025

Conversation

ana-vinogradova-camunda
Copy link
Contributor

@ana-vinogradova-camunda ana-vinogradova-camunda commented Aug 18, 2025 •
edited
Loading

Description

Wrap ClientRegistrationRepository creation in try/catch so we could provide the meaningful error message.

Please feel free to let me know if we'd like to modify the error message to be something else.
Currently, error message looks like this:

Unable to connect to the Identity Provider endpoint `"
                + issuerUri
                + "'. Double check that it is configured correctly, and if the problem persists, "
                + "contact your external Identity provider.

Checklist

Related issues

closes #34189

@ana-vinogradova-camunda
fix: return meaningful error message
1f0a7f7 
When no IdP is available, wi would like to log a meaningful message.
@ana-vinogradova-camunda
test: integration test
33b4913 
here we'd like to check that the error message is peresent
in case startup fails due to IdP being unavailable.
@github-actions github-actions bot added the component/zeebe Related to the Zeebe component/team label Aug 18, 2025
@ana-vinogradova-camunda ana-vinogradova-camunda marked this pull request as ready for review August 18, 2025 13:03
bmudric
bmudric approved these changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@bmudric bmudric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message looks very clear, thank you!

@ana-vinogradova-camunda ana-vinogradova-camunda added this pull request to the merge queue Aug 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2025
@ana-vinogradova-camunda ana-vinogradova-camunda added this pull request to the merge queue Aug 19, 2025
Merged via the queue into main with commit 8b9c09c Aug 19, 2025
100 of 101 checks passed
@ana-vinogradova-camunda ana-vinogradova-camunda deleted the 34189-return-meaningful-error-if-oidc-provider-is-unavailable branch August 19, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmudric bmudric bmudric approved these changes

Assignees
No one assigned
Labels
component/zeebe Related to the Zeebe component/team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failure to start if OIDC provider is unavailable
2 participants
@ana-vinogradova-camunda @bmudric