fix: change type of session refresh lock attribute to string #36919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmudric
approved these changes
Aug 19, 2025
npepinpe
reviewed
Aug 20, 2025
| @@ -99,6 +99,21 @@ void deleteById() { | |||
| assertThat(webSessionRepository.findById(webSession.getId())).isNull(); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
💭 FYI, we have a RegressionTest annotation, which I find helpful to explain the motivation behind some of the tests or decisions which might look not obvious (e.g. using a string vs object). Typical usage is
@RegressionTest("https://github.com/camunda/camunda/pull/36919")
void shouldBlaBla() {
// ...
}The link would be usually the issue link, or a PR link if there is no issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Session persistence faced error after the lock attribute with object type is added to the session.
org.springframework.core.convert.ConversionFailedException: Failed to convert from type [java.lang.Object] to type [byte[]] for value [java.lang.Object@b9a60e4]Related issues
close #36932