[Backport stable/8.5] Unable to deploy process with boundary event without outgoing flows #36706
+280
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a Parameterized test class covering all supported boundary event types (message, timer, signal, escalation, error, compensation) in both interrupting and non-interrupting modes. Verifies that interrupting events terminate the attached activity and non-interrupting events keep it running to completion. (cherry picked from commit dbc9a3a)
Boundary events no longer require outgoing sequence flows by default. Only compensate boundary events still must have no outgoing flows and a compensation association. - Remove global “must have outgoing” check - Add hasCompensationDefinition guard - Introduce isValidCompensationBoundaryEvent to enforce association - Update validation messages accordingly (cherry picked from commit 9cb86dc)
- CompensationEventTest: expect new message for missing compensation association: “Compensation boundary events must have a compensation association and no outgoing sequence flows” - ZeebeBoundaryEventValidationTest: remove old “must have outgoing” case and add compensation‐specific scenario using the updated validation message (cherry picked from commit e66e109)
(cherry picked from commit ef88915)
1 task
|
The latest Buf updates on your PR. Results from workflow Zeebe CI / protobuf-checks (pull_request).
|
|
@copilot please fix the header issue in class BoundaryEventWithoutOutgoingSequenceFlowTest.java |
There was a problem hiding this comment.
Pull Request Overview
This backport fixes an issue where processes with boundary events without outgoing flows couldn't be deployed properly. The fix specifically addresses validation logic for compensation boundary events, which are allowed to have no outgoing sequence flows when they have a compensation association.
- Updated validation error messages to be more specific about compensation boundary event requirements
- Refactored validation logic to properly handle compensation boundary events vs. other boundary event types
- Added comprehensive test coverage for boundary events without outgoing sequence flows
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| BoundaryEventValidator.java | Updated validation logic to specifically handle compensation boundary events and improved error messages |
| ZeebeBoundaryEventValidationTest.java | Updated test to use compensation boundary event and verify new error message |
| CompensationEventTest.java | Updated expected error message to be more specific about compensation boundary events |
| BoundaryEventWithoutOutgoingSequenceFlowTest.java | Added comprehensive parameterized tests for various boundary event types without outgoing flows |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Not yet 🤷 |
berkaycanbc
approved these changes
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #34459 to
stable/8.5.relates to #33589