-
Notifications
You must be signed in to change notification settings - Fork 693
Description
Description
Due to #37173, we don't run ArchUnit tests in the General Unit Tests CI job.
We should add a new job to the common CI that runs the ArchUnit tests.
Changes must be backported to 8.7, 8.6, and 8.5.
Motivation
The ArchUnit tests help ensure we follow architecture rules across our codebase, and avoid bugs. We should run them in CI.
Currently, it seems not possible to run ArchUnit tests using failsafe, which is why it runs using surefire only. That means it's part of the test
phase and depends on the skipUTs
property.
Simultaneously, the qa
module that the camunda-archunit-tests
is part of is only added when the skipQABuild
property is not specified or set to something other then true
. However, the General Unit Tests are run with skipQABuild
.
To overcome this we can introduce a new CI job to the common CI that runs only the ArchUnit tests. This also helps clarify to developers where the failure comes from.
Considered alternatives
- Find a way to run ArchUnit tests using failsafe - currently no idea how
- Move ArchUnit tests out of qa module - we explicitly considered it qa before, so where else should it go?
Acceptance criteria
- ...
Links
Related PRs:
- revert: "fix: add qa module to root" #37173
- [stable/8.7] revert: "fix: add qa module to root" #37172
- [Backport stable/8.6] ArchUnit rule to support both camelCase and kebab-case in ConditionalOnProperty #37051
- [Backport stable/8.5] ArchUnit rule to support both camelCase and kebab-case in ConditionalOnProperty #37049
Slack:
Breakdown
No response