Skip to content

Run ArchUnit tests in CI #37176

@korthout

Description

@korthout

Description

Due to #37173, we don't run ArchUnit tests in the General Unit Tests CI job.

We should add a new job to the common CI that runs the ArchUnit tests.

Changes must be backported to 8.7, 8.6, and 8.5.

Motivation

The ArchUnit tests help ensure we follow architecture rules across our codebase, and avoid bugs. We should run them in CI.

Currently, it seems not possible to run ArchUnit tests using failsafe, which is why it runs using surefire only. That means it's part of the test phase and depends on the skipUTs property.

Simultaneously, the qa module that the camunda-archunit-tests is part of is only added when the skipQABuild property is not specified or set to something other then true. However, the General Unit Tests are run with skipQABuild.

To overcome this we can introduce a new CI job to the common CI that runs only the ArchUnit tests. This also helps clarify to developers where the failure comes from.

Considered alternatives

  • Find a way to run ArchUnit tests using failsafe - currently no idea how
  • Move ArchUnit tests out of qa module - we explicitly considered it qa before, so where else should it go?

Acceptance criteria

  • ...

Links

Related PRs:

Slack:

Breakdown

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/buildMarks an issue as related to our build pipeline (e.g. Maven settings, CI, etc.)area/testMarks an issue as improving or extending the test coverage of the projectkind/taskCategorizes an issue as a breakdown of low-level implementation detail from a parent issueneeds component labelAutomatically added if component was not clear during issue creation

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions