test/toolkits/test_wechat_official_toolkit.py (3)

15-22: Fix import ordering to satisfy Ruff I001.

Sort the multi-name import and keep groups separated (stdlib → third-party → first-party).

Apply:

-from unittest.mock import MagicMock, patch
-
-import pytest
-
-from camel.toolkits.wechat_official_toolkit import (
-    WeChatOfficialToolkit,
-    _get_wechat_access_token,
-)
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from camel.toolkits.wechat_official_toolkit import (
+    _get_wechat_access_token,
+    WeChatOfficialToolkit,
+)

---

44-56: Avoid testing private function directly.

Importing and asserting on _get_wechat_access_token couples tests to internals. Prefer exercising token fetch via public methods (e.g., get_user_info) with requests.get patched.

If you’d like, I can provide a revised test that asserts token usage through get_user_info while stubbing requests.get and _make_wechat_request.

---

37-42: Make tool enumeration test resilient.

Asserting count==6 is brittle. Assert expected tool names instead.

Example:

-    tools = toolkit.get_tools()
-    assert len(tools) == 6
+    tool_names = {t.func.__name__ for t in toolkit.get_tools()}
+    assert {
+        "send_customer_message",
+        "get_user_info",
+        "get_followers_list",
+        "upload_wechat_media",
+        "get_media_list",
+        "send_mass_message_to_all",
+    }.issubset(tool_names)

examples/toolkits/wechat_official_toolkit.py (3)

14-18: Sort imports (I001) and group by origin.

Order internal modules alphabetically to align with style and pre-commit.

Apply:

-from camel.agents import ChatAgent
-from camel.models import ModelFactory
-from camel.toolkits import WeChatOfficialToolkit
-from camel.types import ModelPlatformType, ModelType
+from camel.agents import ChatAgent
+from camel.models import ModelFactory
+from camel.toolkits import WeChatOfficialToolkit
+from camel.types import ModelPlatformType, ModelType

Note: If ruff still flags I001, run isort/ruff --fix on the file.

---

47-50: Avoid absolute paths in examples.

Use a relative asset path or env-configurable path so the example runs anywhere.

Apply:

-    image_path = "/home/lyz/Camel/CAMEL_logo.jpg"  # Update this path as needed
+    from pathlib import Path
+    image_path = str(Path(__file__).with_suffix("").parent.parent / "assets" / "CAMEL_logo.jpg")

Also applies to: 68-70

---

36-44: Wrap overly long lines to pass E501.

Break long strings with parentheses or implicit concatenation; same for f-strings.

Example:

-    response = agent.step(
-        "Get the list of followers, then send a welcome message to the fifth follower."
-    )
+    response = agent.step(
+        (
+            "Get the list of followers, then send a welcome message "
+            "to the fifth follower."
+        )
+    )

Repeat for similar occurrences below.

Also applies to: 46-55, 57-65, 67-75

camel/toolkits/wechat_official_toolkit.py (3)

64-66: Wrap long lines to satisfy E501.

Break long expressions and messages per Google style (80 cols).

Apply examples:

-        _wechat_access_token_expires_at = time.time() + data.get("expires_in", 7200) - 60
+        _wechat_access_token_expires_at = (
+            time.time() + data.get("expires_in", 7200) - 60
+        )

-def _make_wechat_request(method: Literal["GET", "POST"], endpoint: str, **kwargs) -> Dict[str, Any]:
+def _make_wechat_request(
+    method: Literal["GET", "POST"],
+    endpoint: str,
+    **kwargs,
+) -> Dict[str, Any]:

-            raise ValueError(
-                "WeChat credentials missing. Set WECHAT_APP_ID and WECHAT_APP_SECRET."
-            )
+            raise ValueError(
+                "WeChat credentials missing. "
+                "Set WECHAT_APP_ID and WECHAT_APP_SECRET."
+            )

-            lang (str): Response language. Common values: "zh_CN", "zh_TW", "en". (default: "zh_CN")
+            lang (str): Response language. Common values: "zh_CN", "zh_TW",
+                "en". (default: "zh_CN")

Also applies to: 72-86, 136-139, 206-207

---

103-111: Optional: introduce a dedicated exception for API errors.

Raising ValueError with long messages (TRY003) is noisy. A small WeChatAPIError improves clarity.

Example:

+class WeChatAPIError(RuntimeError):
+    pass
@@
-        raise ValueError(f"WeChat API error {errcode}: {errmsg}")
+        raise WeChatAPIError(f"WeChat API error {errcode}: {errmsg}")

And update other ValueError sites similarly if desired.

Also applies to: 167-184

---

28-31: Optional: key token cache by credentials.

If env vars change at runtime/tests, the single global token can leak across creds. Cache per (app_id, app_secret).

I can draft a small token cache map if you want this now.

Also applies to: 48-53

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.