Skip to content

feat: Adding workflow permission checks inside of eventTypes #23038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 26, 2025
Merged

feat: Adding workflow permission checks inside of eventTypes #23038

merged 4 commits into from
Aug 26, 2025

Conversation

sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented Aug 12, 2025 •
edited
Loading

PR adds permissions for eventType + workflows to context on inital load of a eventType. Allows us to easily check permissions in nested client components. In this case we hide the workflows tab if the user does not have permission to create/update etc .

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 12, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/workflows-event-types

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 12, 2025 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Adding workflow permission checks inside of eventTypes". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@graphite-app graphite-app bot requested a review from a team August 12, 2025 12:25
@keithwillcode keithwillcode added consumer core area: core, team members only labels Aug 12, 2025
@dosubot dosubot bot added workflows area: workflows, automations ✨ feature New feature or request labels Aug 12, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 12, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (08/12/25)

1 reviewer was added to this PR based on Keith Williams's automation.

@vercel Vercel
Copy link

vercel bot commented Aug 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal ⬜️ Ignored Aug 12, 2025 1:21pm
cal-eu ⬜️ Ignored Aug 12, 2025 1:21pm

sean-brydon
sean-brydon commented Aug 12, 2025
View reviewed changes
packages/trpc/server/routers/viewer/workflows/getAllActiveWorkflows.handler.ts
Comment on lines +32 to +33
!eventType.teamId &&
!eventType.parent?.teamId
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a bug in main i found when you are not the person that created the eventType - you never have access to it even tho you pass the permission checks on teams below

@sean-brydon sean-brydon requested review from a team as code owners August 12, 2025 13:21
@sean-brydon sean-brydon mentioned this pull request Aug 12, 2025
Open
@hbjORbj hbjORbj changed the title Adding workflow permission checks inside of eventTypes feat: Adding workflow permission checks inside of eventTypes Aug 13, 2025
hbjORbj
hbjORbj reviewed Aug 13, 2025
View reviewed changes
Copy link
Contributor

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great to me. Would be better if you can post some demo videos to prove that the changes achieve what they are supposed to do.

ThyMinimalDev
ThyMinimalDev reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@ThyMinimalDev ThyMinimalDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@keithwillcode keithwillcode requested a review from a team August 26, 2025 11:34
@keithwillcode keithwillcode merged commit 8f4f177 into feat/event-type-pbac Aug 26, 2025
16 of 18 checks passed
@keithwillcode keithwillcode deleted the chore/workflows-event-types branch August 26, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj left review comments

@ThyMinimalDev ThyMinimalDev ThyMinimalDev left review comments

Assignees
No one assigned
Labels
consumer core area: core, team members only ✨ feature New feature or request ready-for-e2e workflows area: workflows, automations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sean-brydon @hbjORbj @ThyMinimalDev @keithwillcode