packages/lib/server/locales/en/common.json (1)

649-661: Potential duplication with existing “continue_as_guest” and semantic overlap

The new keys:

"continue_as_guest": "Continue as Guest",
"join_as_guest": "Join as Guest",
"ideal_for_one_time_calls": "Ideal for one-time calls",

all describe the guest-join action. Unless the UI explicitly needs two different verbs (“Continue” vs “Join”), consider consolidating to a single key to avoid unnecessary translation effort and future maintenance confusion.

If both are really needed, add developer comments in the JSON explaining the contextual difference.

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

apps/web/modules/videos/views/videos-single-view.tsx (1)

404-404: Encode callback URL to prevent security issues.

The callbackUrl parameter should be URL-encoded to prevent broken URLs and potential security issues.

Apply this fix to properly encode the callback URL:

-                (window.location.href = `${WEBAPP_URL}/auth/login?callbackUrl=${WEBAPP_URL}/video/${bookingUid}`)
+                (window.location.href = `${WEBAPP_URL}/auth/login?callbackUrl=${encodeURIComponent(`${WEBAPP_URL}/video/${bookingUid}`)}`)

apps/web/modules/videos/views/videos-single-view.tsx (1)

53-118: Comprehensive call frame creation with localization.

The createCallFrame callback properly:

• Configures Daily theme and layout
• Handles optional userName parameter
• Adds localized tray buttons for team plans
• Includes proper error handling with fallback

However, there's redundant userName setting on Line 109.

Remove the redundant setUserName call since userName is already passed in the createFrame options:

-        if (userName) {
-          callFrame.setUserName(userName);
-        }

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: Udit-takkar
PR: calcom/cal.com#22919
File: packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts:212-220
Timestamp: 2025-08-08T10:26:13.352Z
Learning: In calcom/cal.com PR #22919, packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts should include the phone number in client-facing HttpError messages (e.g., in updatePhoneNumber/getPhoneNumber catch blocks). Do not suggest redacting the phone number from these errors unless requirements change (per maintainer: Udit-takkar).

Learnt from: Anshumancanrock
PR: calcom/cal.com#22570
File: apps/web/modules/signup-view.tsx:253-253
Timestamp: 2025-07-21T21:33:23.371Z
Learning: In signup-view.tsx, when checking if redirectUrl contains certain strings, using explicit && checks (redirectUrl && redirectUrl.includes()) is preferred over optional chaining (redirectUrl?.includes()) to ensure the result is always a boolean rather than potentially undefined. This approach provides cleaner boolean contracts for downstream conditional logic.

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: Applies to **/*.tsx : Always use `t()` for text localization in frontend code; direct text embedding should trigger a warning

apps/web/modules/videos/views/videos-single-view.tsx (2)

405-413: URL-encode callbackUrl before redirect

The callbackUrl should be encoded to prevent breaking the login URL and to avoid injection via query params.

-              onClick={() =>
-                (window.location.href = `${WEBAPP_URL}/auth/login?callbackUrl=${WEBAPP_URL}/video/${bookingUid}`)
-              }>
+              onClick={() => {
+                const callbackUrl = encodeURIComponent(`${WEBAPP_URL}/video/${bookingUid}`);
+                window.location.href = `${WEBAPP_URL}/auth/login?callbackUrl=${callbackUrl}`;
+              }}>

---

153-154: Effect dependencies missing loggedInUserName/overrideName

The effect branches on loggedInUserName and overrideName but they’re not in the dependency array. If either becomes available later (e.g., hydration or async props), the effect won’t re-run and the call may not be created as expected.

-  }, [displayLogInOverlay, isUserNameConfirmed, userNameForCall, createCallFrame]);
+  }, [
+    displayLogInOverlay,
+    isUserNameConfirmed,
+    userNameForCall,
+    createCallFrame,
+    loggedInUserName,
+    overrideName
+  ]);

apps/web/modules/videos/views/videos-single-view.tsx (4)

319-331: Avoid double-confirm pathway; rely on onJoinAsGuest only

After removing the optional onUserNameConfirmed, calling only onJoinAsGuest keeps the state single-sourced from the parent.

-      onJoinAsGuest(trimmedName);
-      onUserNameConfirmed?.();
+      onJoinAsGuest(trimmedName);
       setIsOpen(false);

---

108-110: Remove redundant userName set on callFrame

You already pass userName to createFrame; calling setUserName again is unnecessary.

-        if (userName) {
-          callFrame.setUserName(userName);
-        }

---

50-51: Auto-confirm name when already known (logged-in or overrideName)

This tightens the contract and avoids showing the overlay logic in edge cases. Parent gating covers it, but making the initial state explicit improves readability and reduces surprises.

-  const [isUserNameConfirmed, setIsUserNameConfirmed] = useState<boolean>(!displayLogInOverlay);
+  const [isUserNameConfirmed, setIsUserNameConfirmed] = useState<boolean>(
+    !displayLogInOverlay || !!loggedInUserName || !!overrideName
+  );

---

496-503: Localize aria-label text

Front-end rule: wrap user-facing text in t(). The aria-label here uses plain English strings.

-            aria-label={`${open ? "close" : "open"} booking description sidebar`}
+            aria-label={`${open ? t("close") : t("open")} ${t("booking_description_sidebar")}`}

Also consider localizing the alt attributes for the logos above (Line 188, 198).

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: Udit-takkar
PR: calcom/cal.com#22919
File: packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts:212-220
Timestamp: 2025-08-08T10:26:13.352Z
Learning: In calcom/cal.com PR #22919, packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts should include the phone number in client-facing HttpError messages (e.g., in updatePhoneNumber/getPhoneNumber catch blocks). Do not suggest redacting the phone number from these errors unless requirements change (per maintainer: Udit-takkar).

Learnt from: Anshumancanrock
PR: calcom/cal.com#22570
File: apps/web/modules/signup-view.tsx:253-253
Timestamp: 2025-07-21T21:33:23.371Z
Learning: In signup-view.tsx, when checking if redirectUrl contains certain strings, using explicit && checks (redirectUrl && redirectUrl.includes()) is preferred over optional chaining (redirectUrl?.includes()) to ensure the result is always a boolean rather than potentially undefined. This approach provides cleaner boolean contracts for downstream conditional logic.

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: Applies to **/*.tsx : Always use `t()` for text localization in frontend code; direct text embedding should trigger a warning

apps/web/modules/videos/views/videos-single-view.tsx (7)

87-88: Hard-coded strings require localization.

The label and tooltip strings "Record" and "Start or stop recording" are user-visible but not wrapped in t(). According to the frontend coding guidelines, all text should be localized.

---

97-98: Hard-coded strings require localization.

The label and tooltip strings "Transcribe" and "Transcription powered by AI" are user-visible but not wrapped in t().

---

117-117: Add missing t dependency to useCallback.

The createCallFrame function uses t() for localization but doesn't include it in the dependency array. This could lead to stale translations if the locale changes.

---

201-210: Simplify overlay rendering conditions.

The overlay is currently rendered for logged-in users and when overrideName is present, which contradicts the PR objectives. The component should only render for actual guest users.

---

286-293: Remove unused props from LogInOverlayProps interface.

With proper gating in the parent component, the overlay should only be shown to guests. The isLoggedIn, loggedInUserName, and overrideName props are unnecessary.

---

300-301: Simplify overlay state management.

Since the overlay should only be shown to guests (after parent gating), the isOpen state can default to true and the userName can start empty.

---

404-404: URL encode the callback parameter to prevent injection.

The callbackUrl is directly concatenated into the URL without encoding, which could cause issues if the bookingUid contains special characters.

-                (window.location.href = `${WEBAPP_URL}/auth/login?callbackUrl=${WEBAPP_URL}/video/${bookingUid}`)
+                (window.location.href = `${WEBAPP_URL}/auth/login?callbackUrl=${encodeURIComponent(`${WEBAPP_URL}/video/${bookingUid}`)}`)

apps/web/modules/videos/views/videos-single-view.tsx (3)

108-110: Remove redundant setUserName call.

The userName is already passed to createFrame({ userName }) on line 80, making the explicit call to callFrame.setUserName(userName) redundant.

-        if (userName) {
-          callFrame.setUserName(userName);
-        }

---

121-123: Consider simplifying the overlay gating logic.

The current condition checks three separate variables to determine if the overlay should block call creation. This could be simplified by initializing isUserNameConfirmed based on these conditions.

Initialize isUserNameConfirmed to handle authenticated users automatically:

-  const [isUserNameConfirmed, setIsUserNameConfirmed] = useState<boolean>(!displayLogInOverlay);
+  const [isUserNameConfirmed, setIsUserNameConfirmed] = useState<boolean>(
+    !displayLogInOverlay || !!loggedInUserName || !!overrideName
+  );

Then simplify the effect guard:

-    if (displayLogInOverlay && !loggedInUserName && !overrideName && !isUserNameConfirmed) {
+    if (!isUserNameConfirmed) {
       return;
     }

---

152-154: Inconsistent return value for validation failure.

The function returns false when validation fails but doesn't return anything on success, creating an inconsistent API.

   const trimmedName = guestName.trim();
   if (!trimmedName) {
     return false;
   }
 
   setUserNameForCall(trimmedName);
   setIsUserNameConfirmed(true);
+  return true;

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

Learnt from: Udit-takkar
PR: calcom/cal.com#22919
File: packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts:212-220
Timestamp: 2025-08-08T10:26:13.352Z
Learning: In calcom/cal.com PR #22919, packages/features/calAIPhone/providers/retellAI/services/PhoneNumberService.ts should include the phone number in client-facing HttpError messages (e.g., in updatePhoneNumber/getPhoneNumber catch blocks). Do not suggest redacting the phone number from these errors unless requirements change (per maintainer: Udit-takkar).

Learnt from: Anshumancanrock
PR: calcom/cal.com#22570
File: apps/web/modules/signup-view.tsx:253-253
Timestamp: 2025-07-21T21:33:23.371Z
Learning: In signup-view.tsx, when checking if redirectUrl contains certain strings, using explicit && checks (redirectUrl && redirectUrl.includes()) is preferred over optional chaining (redirectUrl?.includes()) to ensure the result is always a boolean rather than potentially undefined. This approach provides cleaner boolean contracts for downstream conditional logic.

Learnt from: CR
PR: calcom/cal.com#0
File: .cursor/rules/review.mdc:0-0
Timestamp: 2025-07-28T11:50:23.946Z
Learning: Applies to **/*.tsx : Always use `t()` for text localization in frontend code; direct text embedding should trigger a warning