Skip to content

feat: add PATCH endpoint for updating Google Calendar events #22339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 86 commits into from
Aug 13, 2025
Merged

feat: add PATCH endpoint for updating Google Calendar events #22339

merged 86 commits into from
Aug 13, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

@devin-ai-integration devin-ai-integration bot commented Jul 9, 2025 •
edited by jhintu
Loading

@devin-ai-integration
feat: add PATCH endpoint for updating Google Calendar events
141aca0 
- Create UpdateUnifiedCalendarEventInput DTO with optional fields for partial updates
- Add PATCH /:calendar/event/:eventUid endpoint to CalUnifiedCalendarsController
- Extend GoogleCalendarService with updateEventDetails method
- Support updating title, description, start/end times for Google Calendar events
- Follow existing patterns for validation, error handling, and response transformation
- Initially support Google Calendar only with extensibility for other providers

Co-Authored-By: somay@cal.com <somay@cal.com>
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@vercel Vercel
Copy link

vercel bot commented Jul 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal ⬜️ Ignored Preview Aug 13, 2025 3:11pm
cal-eu ⬜️ Ignored Preview Aug 13, 2025 3:11pm

@delve-auditor Delve Auditor
Copy link

delve-auditor bot commented Jul 9, 2025 •
edited
Loading

✅ No security or compliance issues detected. Reviewed everything up to db95950.

Security Overview
  • 🔎 Scanned files: 9 changed file(s)
Detected Code Changes
Change Type Relevant files
Enhancement ► cal-unified-calendars.controller.ts
    Add PATCH endpoint for calendar events
► update-unified-calendar-event.input.ts
    Add input types for calendar event updates
► google-calendar.service.ts
    Add updateEventDetails functionality
► google-calendar-event-input.pipe.ts
    Add transformation logic for Google Calendar events
Other ► get-calendar-event-details-output-pipe.ts
    Fix organizer handling
► documentation.json, openapi.json
    Update API documentation

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@devin-ai-integration
feat: expand PATCH endpoint to support all calendar event fields
b6bba81 
- Add comprehensive field support to UpdateUnifiedCalendarEventInput DTO
- Include locations, attendees, status, and hosts fields with proper validation
- Expand GoogleCalendarService.updateEventDetails to handle complex field transformations
- Add helper methods for response status and event status mapping
- Preserve existing transformation logic from GoogleCalendarEventOutputPipe
- Support conferenceData updates with conferenceDataVersion parameter

Co-Authored-By: somay@cal.com <somay@cal.com>
@vercel vercel bot temporarily deployed to Preview – api July 9, 2025 06:42 Inactive
@vercel vercel bot temporarily deployed to Preview – cal July 9, 2025 06:42 Inactive
@devin-ai-integration
fix: add support for simple location field in Google Calendar events
1253b3f 
- Add handling for geographic location field in addition to conferenceData
- Filter non-video locations for the simple location string field
- Preserve existing conferenceData support for video meetings
- Verified against Google Calendar API documentation

Co-Authored-By: somay@cal.com <somay@cal.com>
@vercel vercel bot temporarily deployed to Preview – api July 9, 2025 06:57 Inactive
@vercel vercel bot temporarily deployed to Preview – cal July 9, 2025 06:57 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 9, 2025 •
edited
Loading

E2E results are ready!

jhintu
jhintu requested changes Jul 14, 2025
View reviewed changes
apps/api/v2/src/modules/cal-unified-calendars/services/google-calendar.service.ts Outdated
bookingReference.delegationCredential
);

const updatePayload: any = {};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createa a sepeare function that does the transormation, or a transformation pipe

@devin-ai-integration
refactor: extract transformation logic into GoogleCalendarEventInputPipe
483ab74 
- Create GoogleCalendarEventInputPipe following existing patterns
- Extract transformation logic from updateEventDetails method
- Move mapping methods to the new pipe for better organization
- Improve code reusability and maintainability

Addresses PR comment requesting transformation logic extraction.

Co-Authored-By: somay@cal.com <somay@cal.com>
@vercel vercel bot temporarily deployed to Preview – api July 14, 2025 10:09 Inactive
@vercel vercel bot temporarily deployed to Preview – cal July 14, 2025 10:09 Inactive
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2025 •
edited
Loading

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@jhintu jhintu marked this pull request as ready for review July 17, 2025 08:30
@jhintu jhintu requested review from a team as code owners July 17, 2025 08:30
@graphite-app graphite-app bot requested a review from a team July 17, 2025 08:30
@supalarry supalarry self-requested a review August 12, 2025 13:01
supalarry
supalarry previously approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@supalarry supalarry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

jhintu
jhintu reviewed Aug 13, 2025
View reviewed changes
.../api/v2/src/ee/event-types-private-links/controllers/event-types-private-links.controller.ts
@@ -53,10 +53,9 @@ export class EventTypesPrivateLinksController {
@ApiHeader(API_KEY_OR_ACCESS_TOKEN_HEADER)
@ApiOperation({ summary: "Get all private links for an event type" })
async getPrivateLinks(
@Param("eventTypeId", ParseIntPipe) eventTypeId: number,
@GetUser("id") userId: number
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused

@jhintu jhintu enabled auto-merge (squash) August 13, 2025 11:09
@supalarry supalarry self-requested a review August 13, 2025 11:22
supalarry
supalarry previously approved these changes Aug 13, 2025
View reviewed changes
jhintu
jhintu previously approved these changes Aug 13, 2025
View reviewed changes
@jhintu jhintu removed the ❗️ migrations contains migration files label Aug 13, 2025
@volnei volnei disabled auto-merge August 13, 2025 14:03
emrysal
emrysal approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@emrysal emrysal merged commit 1914b37 into main Aug 13, 2025
40 checks passed
@emrysal emrysal deleted the devin/1752040351-add-calendar-event-patch-endpoint branch August 13, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emrysal emrysal emrysal approved these changes

@jhintu jhintu jhintu left review comments

@supalarry supalarry supalarry left review comments

Assignees

@jhintu jhintu

Labels
calendar-apps area: calendar, google calendar, outlook, lark, microsoft 365, apple calendar ✨ feature New feature or request ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emrysal @jhintu @supalarry @volnei