-
Notifications
You must be signed in to change notification settings - Fork 10.4k
feat: add drop off funnel chart for /insights/routing #22106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
eunjae-lee
merged 42 commits into
main
from
eunjae/cal-5986-drop-off-funnel-chart-for-insightsrouting
Jul 16, 2025
Merged
feat: add drop off funnel chart for /insights/routing #22106
eunjae-lee
merged 42 commits into
main
from
eunjae/cal-5986-drop-off-funnel-chart-for-insightsrouting
Jul 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
0ab4320
to
4ab828b
Compare
✅ No security or compliance issues detected. Reviewed everything up to 9df6903. Security Overview
Detected Code Changes
Reply to this PR with |
5 tasks
e36c5d1
to
69c1330
Compare
1d7a251
to
a377281
Compare
This was referenced Jul 24, 2025
Closed
This was referenced Aug 22, 2025
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
consumer
core
area: core, team members only
✨ feature
New feature or request
insights
area: insights, analytics
ready-for-e2e
routing-forms
area: routing forms, routing, forms
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add drop off funnel chart for /insights/routing
Summary
This PR adds a drop-off funnel chart visualization to the
/insights/routing
page that shows user progression through routing form steps. The chart displays three key metrics:Key Implementation Details:
getDropOffData
endpoint that uses the InsightsRoutingServiceReview & Testing Checklist for Human
ctx.user.organizationId
is null orinput.selectedTeamId
is undefinedRecommended Test Plan:
Diagram
Notes
main
todevin/insights-services-kysely-1735668293
to properly reflect the stacking relationshipctx.user.organizationId
(nullable) andinput.selectedTeamId
(optional) were being passed to service constructor expecting non-null numbersDemo
Playground
/settings/admin/playground/routing-funnel
Routing Funnel
/insights/routing