feat: filter embed query params from booking success redirects #22028

devin-ai-integration · 2025-06-25T09:02:51Z

Filter embed query params from booking success redirects

Summary

This PR implements a fix to prevent embed query parameters from being forwarded when redirecting to external pages after successful bookings, as requested in issue #20469.

External redirects no longer include embed, layout, embedType, or ui.color-scheme parameters.
Added unit tests to cover all redirect scenarios and parameter filtering.

Link to Devin run

https://app.devin.ai/sessions/60b85483561d4cebb3490659ced24662

Requested by: hariom@cal.com

Fixes #20469

- Add filterEmbedParams option to getNewSearchParams function - Filter out embed, layout, embedType, and ui.color-scheme params when redirecting to external pages - Add comprehensive unit tests for bookingSuccessRedirect covering: - External redirects with and without parameter forwarding - Embed parameter filtering functionality - Internal redirects to booking pages - Booking parameter extraction - All tests pass and type checking succeeds Fixes #20469 Co-Authored-By: hariom@cal.com <hariom@cal.com>

devin-ai-integration · 2025-06-25T09:02:54Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR that start with 'DevinAI'.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment and CI monitoring

vercel · 2025-06-25T09:02:58Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Aug 8, 2025 0:32am
cal-eu	⬜️ Ignored (Inspect)	Visit Preview		Aug 8, 2025 0:32am

delve-auditor · 2025-06-25T09:05:18Z

✅ No security or compliance issues detected. Reviewed everything up to 849788e.

Security Overview

🔎 Scanned files: 2 changed file(s)

Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Co-Authored-By: hariom@cal.com <hariom@cal.com>

graphite-app · 2025-06-25T14:05:21Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (06/25/25)

1 reviewer was added to this PR based on Keith Williams's automation.

github-actions · 2025-06-25T14:37:56Z

E2E results are ready!

Workflow #71162.1 latest results

devin-ai-integration · 2025-07-04T17:03:12Z

Closing due to inactivity for more than 7 days. Configure here.

github-actions · 2025-07-25T00:27:36Z

This PR is being marked as stale due to inactivity.

coderabbitai · 2025-07-25T00:27:44Z

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Join our Discord community for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

…ilter-embed-params-1750841678

…m#22028) * feat: filter embed query params from booking success redirects - Add filterEmbedParams option to getNewSearchParams function - Filter out embed, layout, embedType, and ui.color-scheme params when redirecting to external pages - Add comprehensive unit tests for bookingSuccessRedirect covering: - External redirects with and without parameter forwarding - Embed parameter filtering functionality - Internal redirects to booking pages - Booking parameter extraction - All tests pass and type checking succeeds Fixes calcom#20469 Co-Authored-By: hariom@cal.com <hariom@cal.com> * chore: retrigger CI checks Co-Authored-By: hariom@cal.com <hariom@cal.com> * chore: remove temporary CI retrigger file Co-Authored-By: hariom@cal.com <hariom@cal.com> * Handle a case --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: hariom@cal.com <hariom@cal.com> Co-authored-by: Hariom Balhara <hariombalhara@gmail.com>

github-actions bot added automated-tests area: unit tests, e2e tests, playwright embed area: embed, widget, react embed Low priority Created by Linear-GitHub Sync labels Jun 25, 2025

vercel bot deployed to Preview – dev June 25, 2025 09:28 View deployment

devin-ai-integration bot and others added 2 commits June 25, 2025 11:04

chore: retrigger CI checks

a84576a

Co-Authored-By: hariom@cal.com <hariom@cal.com>

chore: remove temporary CI retrigger file

fe91b86

Co-Authored-By: hariom@cal.com <hariom@cal.com>

vercel bot deployed to Preview – dev June 25, 2025 11:39 View deployment

Merge branch 'main' into devin/filter-embed-params-1750841678

2107642

vercel bot temporarily deployed to Preview – api June 25, 2025 12:54 Inactive

vercel bot deployed to Preview – dev June 25, 2025 13:17 View deployment

hariombalhara self-assigned this Jun 25, 2025

hariombalhara added ready-for-e2e Medium priority Created by Linear-GitHub Sync and removed Low priority Created by Linear-GitHub Sync labels Jun 25, 2025

Handle a case

803c68d

github-actions bot added the Low priority Created by Linear-GitHub Sync label Jun 25, 2025

hariombalhara marked this pull request as ready for review June 25, 2025 14:02

graphite-app bot requested a review from a team June 25, 2025 14:03

vercel bot deployed to Preview – dev June 25, 2025 14:33 View deployment

dosubot bot added booking-page area: booking page, public booking page, booker ✨ feature New feature or request labels Jun 25, 2025

Merge branch 'main' into devin/filter-embed-params-1750841678

849788e

vercel bot deployed to Preview – dev June 26, 2025 08:57 View deployment

devin-ai-integration bot closed this Jul 4, 2025

hariombalhara reopened this Jul 8, 2025

hariombalhara mentioned this pull request Jul 8, 2025

fix: improve redirect parameter handling for success page #20764

Merged

3 tasks

hariombalhara removed their assignment Jul 10, 2025

github-actions bot added the Stale label Jul 25, 2025

Merge branch 'main' of https://github.com/calcom/cal.com into devin/f…

5c76535

…ilter-embed-params-1750841678

vercel bot deployed to Preview – dev August 8, 2025 13:19 View deployment

hariombalhara removed the Stale label Aug 8, 2025

hariombalhara enabled auto-merge (squash) August 8, 2025 13:42

hariombalhara approved these changes Aug 8, 2025

View reviewed changes

hariombalhara merged commit 4d662d3 into main Aug 8, 2025
38 checks passed

hariombalhara deleted the devin/filter-embed-params-1750841678 branch August 8, 2025 13:42

hariombalhara mentioned this pull request Aug 8, 2025

Forwarded parameter cause page not to load correctly #22965

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: filter embed query params from booking success redirects #22028

feat: filter embed query params from booking success redirects #22028

Uh oh!

devin-ai-integration bot commented Jun 25, 2025 •

edited by hariombalhara

Loading

Uh oh!

devin-ai-integration bot commented Jun 25, 2025

Uh oh!

vercel bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

delve-auditor bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jun 25, 2025

Uh oh!

github-actions bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

devin-ai-integration bot commented Jul 4, 2025

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

feat: filter embed query params from booking success redirects #22028

feat: filter embed query params from booking success redirects #22028

Uh oh!

Conversation

devin-ai-integration bot commented Jun 25, 2025 • edited by hariombalhara Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Filter embed query params from booking success redirects

Summary

Link to Devin run

Uh oh!

devin-ai-integration bot commented Jun 25, 2025

🤖 Devin AI Engineer

Uh oh!

vercel bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

delve-auditor bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jun 25, 2025

Graphite Automations

Uh oh!

github-actions bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

devin-ai-integration bot commented Jul 4, 2025

Uh oh!

github-actions bot commented Jul 25, 2025

Uh oh!

coderabbitai bot commented Jul 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

devin-ai-integration bot commented Jun 25, 2025 •

edited by hariombalhara

Loading

vercel bot commented Jun 25, 2025 •

edited

Loading

delve-auditor bot commented Jun 25, 2025 •

edited

Loading

github-actions bot commented Jun 25, 2025 •

edited

Loading

coderabbitai bot commented Jul 25, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)