Skip to content

fix: Remove Reporting page within Routing Forms #22990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 11, 2025
Merged

fix: Remove Reporting page within Routing Forms #22990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/app-store/routing-forms/pages/app-routing.client-config.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,5 @@ export const routingFormsComponents = {
"form-edit": () => import("./form-edit/[...appPages]").then((mod) => mod.default),
"route-builder": () => import("./route-builder/[...appPages]").then((mod) => mod.default),
"routing-link": () => import("./routing-link/[...appPages]").then((mod) => mod.default),
reporting: () => import("./reporting/[...appPages]").then((mod) => mod.default),
"incomplete-booking": () => import("./incomplete-booking/[...appPages]").then((mod) => mod.default),
};
292 changes: 0 additions & 292 deletions packages/app-store/routing-forms/pages/reporting/[...appPages].tsx
View file
Open in desktop

This file was deleted.

46 changes: 0 additions & 46 deletions packages/app-store/routing-forms/playwright/tests/basic.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,52 +408,6 @@ test.describe("Routing Forms", () => {
// Log back in to view form responses.
await user.apiLogin();

await page.goto(`/routing-forms/reporting/${routingForm.id}`);

const headerEls = page.locator("[data-testid='reporting-header'] th");

// Wait for the headers to be visible(will automaically wait for getting response from backend) along with it the rows are rendered.
await headerEls.first().waitFor();

const numHeaderEls = await headerEls.count();
const headers = [];
for (let i = 0; i < numHeaderEls; i++) {
headers.push(await headerEls.nth(i).innerText());
}

const responses = [];
const responseRows = page.locator("[data-testid='reporting-row']");
const numResponseRows = await responseRows.count();
for (let i = 0; i < numResponseRows; i++) {
const rowLocator = responseRows.nth(i).locator("td");
const numRowEls = await rowLocator.count();
const rowResponses = [];
for (let j = 0; j < numRowEls; j++) {
rowResponses.push(await rowLocator.nth(j).innerText());
}
responses.push(rowResponses);
}

expect(headers).toEqual([
"Test field",
"Multi Select(with Legacy `selectText`)",
"Multi Select",
"Legacy Select",
"Select",
// TODO: Find a way to incorporate Routed To and Booked At into the report
// @see https://github.com/calcom/cal.com/pull/17229
"Routed To",
"Assignment Reason",
"Booked At",
"Submitted At",
]);
/* Last two columns are "Routed To" and "Booked At" */
expect(responses).toEqual([
["custom-page", "Option-2", "Option-2", "Option-2", "Option-2", "", "", "", expect.any(String)],
["external-redirect", "Option-2", "Option-2", "Option-2", "Option-2", "", "", "", expect.any(String)],
["event-routing", "Option-2", "Option-2", "Option-2", "Option-2", "", "", "", expect.any(String)],
]);

await page.goto(`apps/routing-forms/route-builder/${routingForm.id}`);

const downloadPromise = page.waitForEvent("download");
Expand Down
5 changes: 1 addition & 4 deletions packages/features/shell/Shell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ import { useAppTheme } from "./useAppTheme";
const Layout = (props: LayoutProps) => {
const { banners, bannersHeight } = useBanners();
const pathname = usePathname();
const isFullPageWithoutSidebar = pathname?.startsWith("/apps/routing-forms/reporting/");

useFormbricks();

Expand All @@ -40,9 +39,7 @@ const Layout = (props: LayoutProps) => {
<TimezoneChangeDialog />

<div className="flex min-h-screen flex-col">
{banners && !props.isPlatformUser && !isFullPageWithoutSidebar && (
<BannerContainer banners={banners} />
)}
{banners && !props.isPlatformUser && <BannerContainer banners={banners} />}

<div className="flex flex-1" data-testid="dashboard-shell">
{props.SidebarContainer ? (
Expand Down
Loading