Skip to content

chore: Add zoom waiting room setting #22888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2025
Merged

chore: Add zoom waiting room setting #22888

merged 4 commits into from
Aug 8, 2025

Conversation

anikdhabal
Copy link
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@vercel Vercel
Copy link

vercel bot commented Aug 4, 2025

@anikdhabal is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team August 4, 2025 15:30
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 4, 2025 •
edited
Loading

Walkthrough

The changes update the Zoom user settings schema by adding an optional nested object meeting_security containing waiting_room_settings with three optional fields: participants_to_place_in_waiting_room, users_who_can_admit_participants_from_waiting_room, and whitelisted_domains_for_waiting_room. The API filter string is updated to include waiting_room_settings to fetch these fields. In the event translation logic, the waiting_room_settings are extracted from userSettings.meeting_security and, if enabled, merged into the meeting settings payload for Zoom meeting creation or update.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7b5a5c2 and cd6646c.

📒 Files selected for processing (1)
  • packages/app-store/zoomvideo/lib/VideoApiAdapter.ts (3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/app-store/zoomvideo/lib/VideoApiAdapter.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Install dependencies / Yarn install & cache
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@keithwillcode keithwillcode added the core area: core, team members only label Aug 4, 2025
@dosubot dosubot bot added the app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar label Aug 4, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 4, 2025 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (08/04/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (08/05/25)

1 label was added to this PR based on Keith Williams's automation.

@anikdhabal anikdhabal changed the title chore: zoom waiting room setting chore: Add zoom waiting room setting Aug 4, 2025
@anikdhabal anikdhabal enabled auto-merge (squash) August 5, 2025 17:43
kart1ka
kart1ka previously approved these changes Aug 5, 2025
View reviewed changes
@anikdhabal anikdhabal marked this pull request as draft August 5, 2025 17:48
auto-merge was automatically disabled August 5, 2025 17:48

Pull request was converted to draft

@anikdhabal anikdhabal requested a review from kart1ka August 8, 2025 08:15
@anikdhabal anikdhabal marked this pull request as ready for review August 8, 2025 08:19
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025 •
edited
Loading

E2E results are ready!

@anikdhabal anikdhabal enabled auto-merge (squash) August 8, 2025 10:20
@anikdhabal anikdhabal merged commit c64b663 into calcom:main Aug 8, 2025
31 of 35 checks passed
Pallava-Joshi pushed a commit to Pallava-Joshi/cal.com that referenced this pull request Aug 8, 2025
@anikdhabal @Pallava-Joshi
chore: Add zoom waiting room setting (calcom#22888)
61806db 
* chore: zoom waiting room setting

* Update VideoApiAdapter.ts

* Update VideoApiAdapter.ts
anikdhabal added a commit that referenced this pull request Aug 28, 2025
@anikdhabal
Revert "chore: Add zoom waiting room setting (#22888)"
4d198cf 
This reverts commit c64b663.
@anikdhabal anikdhabal mentioned this pull request Aug 28, 2025
Merged
anikdhabal added a commit that referenced this pull request Aug 28, 2025
@anikdhabal
Revert "chore: Add zoom waiting room setting (#22888)" (#23427)
464e5f1 
This reverts commit c64b663.
@anglerfishlyy anglerfishlyy mentioned this pull request Aug 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kart1ka kart1ka kart1ka approved these changes

Assignees
No one assigned
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar core area: core, team members only ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anikdhabal @kart1ka @keithwillcode