Skip to content

fix: text wrap on /conference #22864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 8, 2025
Merged

fix: text wrap on /conference #22864

merged 2 commits into from
Aug 8, 2025

Conversation

SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented Aug 1, 2025 •
edited
Loading

What does this PR do?

This PR resolves the issue where the conferencing apps descriptions were not wrapped leading to incomplete detail.
Hence i had to wrap the description

Visual Demo (For contributors especially)

Screencast.from.2025-08-01.21-41-14.webm

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 1, 2025 •
edited
Loading

Walkthrough

The changes in the AppListCard.tsx component focus on modifying CSS class assignments to improve flexbox layout and text wrapping behavior. Adjustments include aligning items to the start, adding flex-shrink-0 to prevent shrinking of certain elements, replacing the truncate class with min-w-0 for better text overflow handling, and updating text containers with whitespace-normal break-words to enable multiline wrapping and word breaks. No changes were made to the component's logic or exported/public entity declarations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~7 minutes

Assessment against linked issues

Objective Addressed Explanation
Ensure text wraps in the /conference page for improved legibility (#22862, CAL-6192) ✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 62c352e and a510a2d.

📒 Files selected for processing (1)
  • packages/ui/components/app-list-card/AppListCard.tsx (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/ui/components/app-list-card/AppListCard.tsx
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added 🐛 bug Something isn't working 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Aug 1, 2025
@vercel Vercel
Copy link

vercel bot commented Aug 1, 2025

@SinghaAnirban005 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@SinghaAnirban005 SinghaAnirban005 marked this pull request as ready for review August 1, 2025 16:28
@SinghaAnirban005 SinghaAnirban005 requested review from a team as code owners August 1, 2025 16:28
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Aug 1, 2025
@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label Aug 1, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Aug 1, 2025 •
edited
Loading

Graphite Automations

"Add community label" took an action on this PR • (08/01/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (08/08/25)

1 label was added to this PR based on Keith Williams's automation.

@SinghaAnirban005 SinghaAnirban005 force-pushed the bug/ui branch 2 times, most recently from 00c1742 to 62c352e Compare August 2, 2025 19:17
@kart1ka
Copy link
Contributor

kart1ka commented Aug 5, 2025

@SinghaAnirban005 Tests are failing. Pls check and try to fix them.

@kart1ka kart1ka marked this pull request as draft August 5, 2025 17:30
@SinghaAnirban005 SinghaAnirban005 marked this pull request as ready for review August 5, 2025 17:49
@anikdhabal anikdhabal requested a review from volnei August 8, 2025 05:38
volnei
volnei approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@volnei volnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

E2E results are ready!

@volnei volnei merged commit 26f8246 into calcom:main Aug 8, 2025
54 of 59 checks passed
Pallava-Joshi pushed a commit to Pallava-Joshi/cal.com that referenced this pull request Aug 8, 2025
@SinghaAnirban005 @kart1ka @Pallava-Joshi
fix: text wrap on /conference (calcom#22864)
8912a7f 
Co-authored-by: Kartik Saini <41051387+kart1ka@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volnei volnei volnei approved these changes

@kart1ka kart1ka kart1ka approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e ui area: UI, frontend, button, form, input
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UX/UI - Need Text Wrapping on /Conference
3 participants
@SinghaAnirban005 @kart1ka @volnei