Skip to content

feat: add email and phone number to credit expense log #22846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Sep 4, 2025
Merged

feat: add email and phone number to credit expense log #22846

merged 7 commits into from
Sep 4, 2025
+26 −1

Conversation

shaun-ak
Copy link
Contributor

What does this PR do?

Added email and phone number to credit expense log

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

@shaun-ak shaun-ak requested a review from a team July 31, 2025 15:00
@vercel Vercel
Copy link

vercel bot commented Jul 31, 2025

@shaun-ak is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 31, 2025 •
edited
Loading

"""

Walkthrough

The changes introduce two new optional fields, phoneNumber and email, to the credit expense logging system. These fields are added to the Prisma schema, database migration, and the internal logic for creating and querying expense logs. The methods responsible for charging credits and creating expense logs are updated to accept and propagate these fields. Additionally, the CSV export functionality for expense logs is modified to include the new fields in both headers and data rows. No unrelated logic or structural changes are present.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective Addressed Explanation
Add a phone number and email field to the expense log of the credit system (#22839, CAL-6185) ✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.
"""

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4619227 and b9b7c5c.

📒 Files selected for processing (1)
  • packages/lib/server/repository/credits.test.ts (2 hunks)
✅ Files skipped from review due to trivial changes (1)
  • packages/lib/server/repository/credits.test.ts
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Install dependencies / Yarn install & cache
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jul 31, 2025
@graphite-app graphite-app bot requested a review from a team July 31, 2025 15:00
@github-actions github-actions bot added consumer Medium priority Created by Linear-GitHub Sync Public ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI ❗️ migrations contains migration files labels Jul 31, 2025
@dosubot dosubot bot added the billing area: billing, stripe, payments, paypal, get paid label Jul 31, 2025
@graphite-app Graphite App
Copy link

graphite-app bot commented Jul 31, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/31/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (07/31/25)

1 label was added to this PR based on Keith Williams's automation.

Devanshusharma2005
Devanshusharma2005 reviewed Aug 1, 2025
View reviewed changes
Copy link
Contributor

@Devanshusharma2005 Devanshusharma2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests are failiing. Could you please address them ?

@shaun-ak
Copy link
Contributor Author

shaun-ak commented Aug 2, 2025

@Devanshusharma2005 Fixed the test cases

Devanshusharma2005
Devanshusharma2005 previously approved these changes Aug 12, 2025
View reviewed changes
Copy link
Contributor

@Devanshusharma2005 Devanshusharma2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shaun-ak
Copy link
Contributor Author

Hey @CarinaWolli , can you please review this?

Thanks!

@anikdhabal anikdhabal enabled auto-merge (squash) September 1, 2025 17:38
@volnei volnei disabled auto-merge September 3, 2025 21:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

E2E results are ready!

@anikdhabal anikdhabal merged commit ef114d7 into calcom:main Sep 4, 2025
55 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volnei volnei volnei approved these changes

@anikdhabal anikdhabal anikdhabal approved these changes

@Devanshusharma2005 Devanshusharma2005 Devanshusharma2005 left review comments

Assignees
No one assigned
Labels
billing area: billing, stripe, payments, paypal, get paid community Created by Linear-GitHub Sync consumer ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI Medium priority Created by Linear-GitHub Sync ❗️ migrations contains migration files Public ready-for-e2e
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add a phone number and email field to the expense log of our credit system
4 participants
@shaun-ak @volnei @anikdhabal @Devanshusharma2005