fix: (pbac) edit sheet readonly to all to readonly #22672

sean-brydon · 2025-07-22T09:30:13Z

What does this PR do?

This PR fixes an issue that @joeauyeung found in this PR #22659 (review)

Wasnt caused by this PR so created a seperate PR just for this.

TLDR: when unassigning permissions from a role from all -> readonly -> none nothing was being unassigned via the simple UI. Also when correctly updated the UI state wasnt correct. I.e -> EventType.All wasnt showing if the state came from read only originally

How should this be tested?

Enable PBAC feature flag on a team
Create a role
assign it no permissions -> check db
Assign it read only -> check db
assign it all - > check db
assign it read only -> check db

ensure db and ui state is alligned with what you would expect in this flow.

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

github-actions · 2025-07-22T09:30:25Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "fix readonly to all to readonly". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

coderabbitai · 2025-07-22T09:30:47Z

Walkthrough

This set of changes adds a new test suite for the usePermissions hook, specifically testing the getResourcePermissionLevel function across various permission scenarios, including handling of global wildcard permissions and resource-specific CRUD permissions. The getResourcePermissionLevel function was updated to explicitly check for the global all-permissions wildcard "*.*" and return "all" immediately if present. In the RoleRepository, the permission removal logic in the update method was corrected by changing the delete filter from an AND to an OR condition, ensuring each specified permission is removed individually. The RoleService test suite was expanded with additional fields in permission objects and a new test verifying behavior when updating a role to have no permissions.

Estimated code review effort

3 (~45 minutes)

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/usePermissions.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e0a993a and 4cad3c3.

📒 Files selected for processing (1)

apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/usePermissions.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

apps/web/app/(use-page-wrapper)/settings/(settings-layout)/organizations/roles/_components/usePermissions.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Security Check

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

delve-auditor · 2025-07-22T09:32:36Z

✅ No security or compliance issues detected. Reviewed everything up to ca273d7.

Security Overview

🔎 Scanned files: 4 changed file(s)

Detected Code Changes

Change Type	Relevant files
Enhancement	► usePermissions.test.ts Add tests for permission level handling ► usePermissions.ts Add global permissions check ► role.service.test.ts Add tests for multiple permission removal
Bug Fix	► RoleRepository.ts Fix permission removal logic using OR instead of AND

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

graphite-app · 2025-07-22T09:35:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/22/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (07/22/25)

1 label was added to this PR based on Keith Williams's automation.

vercel · 2025-07-22T12:00:11Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)			Jul 22, 2025 2:26pm
cal-eu	⬜️ Ignored (Inspect)			Jul 22, 2025 2:26pm

emrysal

Nice 👍

github-actions · 2025-07-22T12:29:18Z

E2E results are ready!

Workflow #68998.1 latest results

joeauyeung

LGTM and roles are being updated in the DB when taking away permissions.

sean-brydon added 2 commits July 22, 2025 10:22

fix readonly to all to readonly

3c1e760

fix sheet not showing correct all,readonly,none state until refresh

2ccdbcf

graphite-app bot requested a review from a team July 22, 2025 09:30

keithwillcode added consumer core area: core, team members only labels Jul 22, 2025

vercel bot deployed to Preview – dev July 22, 2025 10:05 View deployment

dosubot bot added teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Jul 22, 2025

sean-brydon changed the title ~~fix readonly to all to readonly~~ fix: (pbac) edit sheet readonly to all to readonly Jul 22, 2025

update test to include the correct roleId

e0a993a

emrysal previously approved these changes Jul 22, 2025

View reviewed changes

graphite-app bot added the ready-for-e2e label Jul 22, 2025

Merge branch 'main' into fix/rolepermission-all-readonly

4cad3c3

emrysal dismissed their stale review via 4cad3c3 July 22, 2025 12:04

emrysal enabled auto-merge (squash) July 22, 2025 12:24

emrysal approved these changes Jul 22, 2025

View reviewed changes

vercel bot deployed to Preview – dev July 22, 2025 12:41 View deployment

joeauyeung approved these changes Jul 22, 2025

View reviewed changes

Merge branch 'main' into fix/rolepermission-all-readonly

ca273d7

vercel bot deployed to Preview – dev July 22, 2025 14:45 View deployment

emrysal merged commit fa47456 into main Jul 22, 2025
39 checks passed

emrysal deleted the fix/rolepermission-all-readonly branch July 22, 2025 14:46

coderabbitai bot mentioned this pull request Jul 28, 2025

fix: remove fallback permssions on organization Id. #22769

Merged

coderabbitai bot mentioned this pull request Aug 11, 2025

revert: "fix: remove fallback permssions on organization Id. (#22769)" #23013

Merged

This was referenced Aug 26, 2025

feat: event type pbac #22618

Open

feat: (PBAC) Introduce depends on permission registery #23440

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: (pbac) edit sheet readonly to all to readonly #22672

fix: (pbac) edit sheet readonly to all to readonly #22672

Uh oh!

sean-brydon commented Jul 22, 2025

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

coderabbitai bot commented Jul 22, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

delve-auditor bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 22, 2025 •

edited

Loading

Uh oh!

emrysal left a comment

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

joeauyeung left a comment

Uh oh!

Uh oh!

Uh oh!

fix: (pbac) edit sheet readonly to all to readonly #22672

fix: (pbac) edit sheet readonly to all to readonly #22672

Uh oh!

Conversation

sean-brydon commented Jul 22, 2025

What does this PR do?

How should this be tested?

Checklist

Uh oh!

github-actions bot commented Jul 22, 2025

Uh oh!

coderabbitai bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Estimated code review effort

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

delve-auditor bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Graphite Automations

Uh oh!

vercel bot commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emrysal left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jul 22, 2025

E2E results are ready!

Uh oh!

joeauyeung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Jul 22, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

delve-auditor bot commented Jul 22, 2025 •

edited

Loading

graphite-app bot commented Jul 22, 2025 •

edited

Loading

vercel bot commented Jul 22, 2025 •

edited

Loading