refactor: update v2 event type booking fields #22634

weknowyourgame · 2025-07-18T18:27:58Z

What does this PR do?

Fixes refactor: updating v2 event type booking fields #22596 (GitHub issue number)
Fixes CAL-6120

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

coderabbitai · 2025-07-18T18:28:07Z

Caution

Review failed

Failed to post review comments.

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 04ce054 and 2f4f177.

📒 Files selected for processing (3)

apps/api/v2/src/ee/event-types/event-types_2024_06_14/event-types.repository.ts (1 hunks)
apps/api/v2/src/ee/event-types/event-types_2024_06_14/services/input-event-types.service.ts (1 hunks)
apps/api/v2/swagger/documentation.json (21 hunks)

🧰 Additional context used

🧠 Learnings (3)

apps/api/v2/src/ee/event-types/event-types_2024_06_14/event-types.repository.ts (2)

Learnt from: vijayraghav-io
PR: calcom/cal.com#21072
File: packages/prisma/schema.prisma:891-891
Timestamp: 2025-07-18T08:47:01.255Z
Learning: In Cal.com's calendar integration, both Google Calendar and Outlook Calendar are designed to allow multiple eventTypeIds to share the same subscription ID (googleChannelId or outlookSubscriptionId). This is an intentional design pattern to reuse existing subscriptions for efficiency rather than creating separate subscriptions for each event type. Therefore, unique constraints like `@@unique([outlookSubscriptionId, eventTypeId])` should not be added as they would break this subscription sharing functionality.

Learnt from: vijayraghav-io
PR: calcom/cal.com#21072
File: packages/prisma/schema.prisma:891-891
Timestamp: 2025-07-18T08:47:01.256Z
Learning: The Outlook Calendar integration in Cal.com intentionally reuses subscription IDs across multiple event types for efficiency. The `upsertSelectedCalendarsForEventTypeIds` method creates separate SelectedCalendar records for each eventTypeId, all sharing the same outlookSubscriptionId. This subscription sharing pattern means that unique constraints like `@@unique([outlookSubscriptionId, eventTypeId])` should not be applied as they would prevent this intended functionality.

apps/api/v2/src/ee/event-types/event-types_2024_06_14/services/input-event-types.service.ts (1)

Learnt from: eunjae-lee
PR: calcom/cal.com#22106
File: packages/features/insights/components/FailedBookingsByField.tsx:65-71
Timestamp: 2025-07-15T12:59:34.341Z
Learning: In the FailedBookingsByField component (packages/features/insights/components/FailedBookingsByField.tsx), although routingFormId is typed as optional in useInsightsParameters, the system automatically enforces a routing form filter, so routingFormId is always present in practice. This means the data always contains only one entry, making the single-entry destructuring approach safe.

apps/api/v2/swagger/documentation.json (1)

undefined

<retrieved_learning>
Learnt from: eunjae-lee
PR: #22106
File: packages/features/insights/components/FailedBookingsByField.tsx:65-71
Timestamp: 2025-07-15T12:59:34.341Z
Learning: In the FailedBookingsByField component (packages/features/insights/components/FailedBookingsByField.tsx), although routingFormId is typed as optional in useInsightsParameters, the system automatically enforces a routing form filter, so routingFormId is always present in practice. This means the data always contains only one entry, making the single-entry destructuring approach safe.
</retrieved_learning>

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Install dependencies / Yarn install & cache
GitHub Check: Security Check

🔇 Additional comments (1)

apps/api/v2/src/ee/event-types/event-types_2024_06_14/event-types.repository.ts (1)

52-67: LGTM! Clean repository methods following established patterns.

The new methods getEventTypeWithBookingFields and getEventTypeWithMetaDataAndBookingFields are well-implemented and consistent with the existing repository pattern.

Walkthrough

This change introduces two new repository methods for selectively fetching booking fields and metadata for event types. The main update revises the booking fields update logic in the event type service: instead of replacing all booking fields when an update request is made, the new implementation merges the input booking fields with those already stored, matching by slug or name, and preserving or updating fields as appropriate. The OpenAPI documentation is also updated, simplifying and clarifying property descriptions for booking fields and their behaviors. No changes are made to the structure or types of the schemas, only to their descriptions.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/api/v2/src/ee/event-types/event-types_2024_06_14/services/input-event-types.service.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".

(The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/apps/api/v2".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install @typescript-eslint/eslint-plugin@latest --save-dev

The plugin "@typescript-eslint/eslint-plugin" was referenced from the config file in "apps/api/v2/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

apps/api/v2/src/ee/event-types/event-types_2024_06_14/event-types.repository.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "@typescript-eslint/eslint-plugin".

(The package "@typescript-eslint/eslint-plugin" was not found when loaded as a Node module from the directory "/apps/api/v2".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install @typescript-eslint/eslint-plugin@latest --save-dev

The plugin "@typescript-eslint/eslint-plugin" was referenced from the config file in "apps/api/v2/.eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-07-18T18:28:08Z

@weknowyourgame is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

graphite-app · 2025-07-18T18:30:12Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/18/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (07/18/25)

1 label was added to this PR based on Keith Williams's automation.

Devanshusharma2005

hey @weknowyourgame thanks for the pr. Could you please add a Postman test to help verify the change? It’ll make it easier to confirm the fix end-to-end.

github-actions · 2025-08-02T00:26:15Z

This PR is being marked as stale due to inactivity.

volnei

This code looks a bit complex and hard to understand, it would be good to extract repeated logic into utility functions and include tests for changes.

github-actions · 2025-08-28T00:24:22Z

This PR is being marked as stale due to inactivity.

refactor: updating v2 event type booking fields

ce9fafe

weknowyourgame requested review from a team as code owners July 18, 2025 18:27

graphite-app bot added the community Created by Linear-GitHub Sync label Jul 18, 2025

graphite-app bot requested a review from a team July 18, 2025 18:28

github-actions bot added api area: API, enterprise API, access token, OAuth platform Anything related to our platform plan Private Created by Linear-GitHub Sync 💻 refactor labels Jul 18, 2025

dosubot bot added the event-types area: event types, event-types label Jul 18, 2025

weknowyourgame force-pushed the refactor-update-v2-event-type-booking-fields branch from 2f4f177 to ce9fafe Compare July 18, 2025 18:32

Merge branch 'main' into refactor-update-v2-event-type-booking-fields

c1c426e

Devanshusharma2005 reviewed Jul 18, 2025

View reviewed changes

github-actions bot added the Stale label Aug 2, 2025

volnei requested changes Aug 12, 2025

View reviewed changes

github-actions bot removed the Stale label Aug 13, 2025

kart1ka marked this pull request as draft August 13, 2025 05:06

github-actions bot added the Stale label Aug 28, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: update v2 event type booking fields #22634

refactor: update v2 event type booking fields #22634

weknowyourgame commented Jul 18, 2025

Uh oh!

coderabbitai bot commented Jul 18, 2025 •

edited

Loading

Review failed

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

vercel bot commented Jul 18, 2025

Uh oh!

graphite-app bot commented Jul 18, 2025

Uh oh!

Devanshusharma2005 left a comment

Uh oh!

github-actions bot commented Aug 2, 2025

Uh oh!

volnei left a comment

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

Uh oh!

refactor: update v2 event type booking fields #22634

Are you sure you want to change the base?

refactor: update v2 event type booking fields #22634

Conversation

weknowyourgame commented Jul 18, 2025

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Uh oh!

coderabbitai bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

vercel bot commented Jul 18, 2025

Uh oh!

graphite-app bot commented Jul 18, 2025

Graphite Automations

Uh oh!

Devanshusharma2005 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 2, 2025

Uh oh!

volnei left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Aug 28, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Jul 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)