fix: remove team plan check #22628

Udit-takkar · 2025-07-18T13:56:42Z

What does this PR do?

We don't need team plan check here as properties like "redirect url on exit" is available for free users as well

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
N/A I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
N/A I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

coderabbitai · 2025-07-18T13:56:49Z

Walkthrough

The update handler in the event types router was modified to remove the import and usage of the hasTeamPlanHandler function. Instead of conditionally checking for a team plan before updating calendar video settings, the handler now directly and unconditionally calls CalVideoSettingsRepository.createOrUpdateCalVideoSettings with the provided settings and event type ID whenever calVideoSettings is present. The conditional logic based on the hasTeamPlan flag was eliminated, resulting in a more streamlined update process for calendar video settings. No changes were made to exported or public entity declarations.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/trpc/server/routers/viewer/eventTypes/update.handler.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2115a04 and c502a4a.

📒 Files selected for processing (1)

packages/trpc/server/routers/viewer/eventTypes/update.handler.ts (1 hunks)

🧰 Additional context used

🧠 Learnings (1)

packages/trpc/server/routers/viewer/eventTypes/update.handler.ts (2)

Learnt from: vijayraghav-io
PR: calcom/cal.com#21072
File: packages/prisma/schema.prisma:891-891
Timestamp: 2025-07-18T08:47:01.255Z
Learning: In Cal.com's calendar integration, both Google Calendar and Outlook Calendar are designed to allow multiple eventTypeIds to share the same subscription ID (googleChannelId or outlookSubscriptionId). This is an intentional design pattern to reuse existing subscriptions for efficiency rather than creating separate subscriptions for each event type. Therefore, unique constraints like `@@unique([outlookSubscriptionId, eventTypeId])` should not be added as they would break this subscription sharing functionality.

Learnt from: vijayraghav-io
PR: calcom/cal.com#21072
File: packages/prisma/schema.prisma:891-891
Timestamp: 2025-07-18T08:47:01.256Z
Learning: The Outlook Calendar integration in Cal.com intentionally reuses subscription IDs across multiple event types for efficiency. The `upsertSelectedCalendarsForEventTypeIds` method creates separate SelectedCalendar records for each eventTypeId, all sharing the same outlookSubscriptionId. This subscription sharing pattern means that unique constraints like `@@unique([outlookSubscriptionId, eventTypeId])` should not be applied as they would prevent this intended functionality.

🧬 Code Graph Analysis (1)

packages/trpc/server/routers/viewer/eventTypes/update.handler.ts (1)

packages/lib/server/repository/calVideoSettings.ts (1)

CalVideoSettingsRepository (3-78)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Check for E2E label
GitHub Check: Security Check

🔇 Additional comments (1)

packages/trpc/server/routers/viewer/eventTypes/update.handler.ts (1)

602-605: Confirm intentional removal of the team plan check for calendar video settings

The updated handler now unconditionally calls
CalVideoSettingsRepository.createOrUpdateCalVideoSettings
when calVideoSettings is provided, whereas other parts of the code (e.g.
workflows/sendVerificationCode.handler.ts) still guard premium features with hasTeamPlanHandler. Please verify that:

Calendar video settings updates should indeed be available to all users regardless of their team plan.

Removing this validation here won’t expose premium functionality that should remain restricted.

Any related documentation or tests are updated to reflect this change.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

supalarry

Thanks for the quick fix!

delve-auditor · 2025-07-18T13:58:57Z

✅ No security or compliance issues detected. Reviewed everything up to bd4bc21.

Security Overview

🔎 Scanned files: 1 changed file(s)

Detected Code Changes

Change Type	Relevant files
Refactor	► update.handler.ts Remove team plan check before updating video settings

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

graphite-app · 2025-07-18T14:00:12Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/18/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (07/18/25)

1 label was added to this PR based on Keith Williams's automation.

github-actions · 2025-07-18T16:15:10Z

E2E results are ready!

Workflow #68608.2 latest results

vercel · 2025-07-18T17:12:43Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)			Jul 18, 2025 5:12pm
cal-eu	⬜️ Ignored (Inspect)			Jul 18, 2025 5:12pm

fix: remove team plan check

c502a4a

graphite-app bot requested a review from a team July 18, 2025 13:56

keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels Jul 18, 2025

Udit-takkar added this to the v5.6 milestone Jul 18, 2025

supalarry approved these changes Jul 18, 2025

View reviewed changes

graphite-app bot added the ready-for-e2e label Jul 18, 2025

dosubot bot added teams area: teams, round robin, collective, managed event-types 🐛 bug Something isn't working labels Jul 18, 2025

vercel bot deployed to Preview – dev July 18, 2025 14:16 View deployment

Udit-takkar enabled auto-merge (squash) July 18, 2025 15:17

anikdhabal added ready-for-e2e and removed ready-for-e2e labels Jul 18, 2025

Merge branch 'main' into fix/remove-team-check

bd4bc21

vercel bot deployed to Preview – dev July 18, 2025 17:33 View deployment

Udit-takkar merged commit 04ce054 into main Jul 18, 2025
61 of 64 checks passed

Udit-takkar deleted the fix/remove-team-check branch July 18, 2025 18:14

zomars pushed a commit that referenced this pull request Jul 22, 2025

fix: remove team plan check (#22628)

b1f98ef

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: remove team plan check #22628

fix: remove team plan check #22628

Uh oh!

Udit-takkar commented Jul 18, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 18, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

supalarry left a comment

Uh oh!

delve-auditor bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Jul 18, 2025

Uh oh!

github-actions bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 18, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

fix: remove team plan check #22628

fix: remove team plan check #22628

Uh oh!

Conversation

Udit-takkar commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Uh oh!

coderabbitai bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

supalarry left a comment

Choose a reason for hiding this comment

Uh oh!

delve-auditor bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot commented Jul 18, 2025

Graphite Automations

Uh oh!

github-actions bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

vercel bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Udit-takkar commented Jul 18, 2025 •

edited

Loading

coderabbitai bot commented Jul 18, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

delve-auditor bot commented Jul 18, 2025 •

edited

Loading

github-actions bot commented Jul 18, 2025 •

edited

Loading

vercel bot commented Jul 18, 2025 •

edited

Loading