fix: API handler response termination logic #22575

zomars · 2025-07-16T23:19:47Z

Removed unnecessary return values after setting status in the integrations API handler. This clarifies response handling and prevents returning the response object when not needed.

Resolves "API handler should not return a value, received object".

This pull request makes a minor adjustment to the apps/web/pages/api/integrations/[...args].ts file. The change simplifies the return statement by removing the redundant res object return and replacing it with a bare return statement. (apps/web/pages/api/integrations/[...args].tsL74-R75)

What does this PR do?

Fixes #XXXX (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

Show screen recordings of the issue or feature.
Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

Add side-by-side screenshots of the original and updated change.
Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

Removed unnecessary return values after setting status in the integrations API handler. This clarifies response handling and prevents returning the response object when not needed. Resolves "API handler should not return a value, received object".

coderabbitai · 2025-07-16T23:19:54Z

Walkthrough

The change updates the response handling logic in the API integration handler. Previously, after invoking the integration handler, the code checked if the response was not finished and then returned the result of setting the response status to 200, followed by returning the response object itself. The revised code sets the status to 200 without returning its result and then explicitly returns undefined, removing the return of the response object or the status call result. No changes were made to the function signatures or exported entities.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

apps/web/pages/api/integrations/[...args].ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4f95cff and 82a2718.

📒 Files selected for processing (1)

apps/web/pages/api/integrations/[...args].ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Install dependencies / Yarn install & cache
GitHub Check: Security Check

🔇 Additional comments (1)

apps/web/pages/api/integrations/[...args].ts (1)

74-75: LGTM! Proper fix for Next.js API handler return value warning.

The changes correctly address the "API handler should not return a value, received object" warning by:

Calling res.status(200) without returning its result

Using a bare return; statement to exit cleanly without returning a value

This follows Next.js API handler best practices where handlers should not return response objects, as the framework automatically handles response sending after handler completion.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-07-16T23:19:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)			Jul 18, 2025 0:02am
cal-eu	⬜️ Ignored (Inspect)			Jul 18, 2025 0:02am

github-actions · 2025-07-16T23:19:55Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Fix API handler response termination logic". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

graphite-app · 2025-07-16T23:20:11Z

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (07/16/25)

1 reviewer was added to this PR based on Keith Williams's automation.

delve-auditor · 2025-07-16T23:22:10Z

✅ No security or compliance issues detected. Reviewed everything up to a20ed70.

Security Overview

🔎 Scanned files: 1 changed file(s)

Detected Code Changes

Change Type	Relevant files
Bug Fix	► [...args].ts Fix API handler response logic

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

emrysal

🚀

github-actions · 2025-07-18T12:26:04Z

E2E results are ready!

Workflow #68551.1 latest results

graphite-app bot requested a review from a team July 16, 2025 23:19

zomars added the ready-for-e2e label Jul 16, 2025

keithwillcode added core area: core, team members only foundation labels Jul 16, 2025

zomars changed the title ~~Fix API handler response termination logic~~ fix: API handler response termination logic Jul 16, 2025

zomars enabled auto-merge (squash) July 16, 2025 23:20

dosubot bot added api area: API, enterprise API, access token, OAuth 🐛 bug Something isn't working labels Jul 16, 2025

vercel bot deployed to Preview – dev July 16, 2025 23:42 View deployment

emrysal approved these changes Jul 18, 2025

View reviewed changes

Merge branch 'main' into fix/api-handler-warning

a20ed70

zomars merged commit f67522d into main Jul 18, 2025
38 of 39 checks passed

zomars deleted the fix/api-handler-warning branch July 18, 2025 12:21

vercel bot deployed to Preview – dev July 18, 2025 12:30 View deployment

zomars added a commit that referenced this pull request Jul 22, 2025

Fix API handler response termination logic (#22575)

6650051

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: API handler response termination logic #22575

fix: API handler response termination logic #22575

Uh oh!

zomars commented Jul 16, 2025

Uh oh!

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

vercel bot commented Jul 16, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

graphite-app bot commented Jul 16, 2025

Uh oh!

delve-auditor bot commented Jul 16, 2025 •

edited

Loading

Uh oh!

emrysal left a comment

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025

Uh oh!

Uh oh!

fix: API handler response termination logic #22575

fix: API handler response termination logic #22575

Uh oh!

Conversation

zomars commented Jul 16, 2025

What does this PR do?

Visual Demo (For contributors especially)

Video Demo (if applicable):

Image Demo (if applicable):

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

Uh oh!

coderabbitai bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

vercel bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 16, 2025

Uh oh!

graphite-app bot commented Jul 16, 2025

Graphite Automations

Uh oh!

delve-auditor bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

emrysal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 18, 2025

E2E results are ready!

Uh oh!

Uh oh!

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

vercel bot commented Jul 16, 2025 •

edited

Loading

delve-auditor bot commented Jul 16, 2025 •

edited

Loading