fix(payment): only send payment email to booking user in seated events #22558

DarshanKumarA · 2025-07-16T13:01:23Z

Fixes #22524 – Prevents duplicate payment emails to all users and only send payment email to booking user in seated events

What does this PR do?

This PR ensures that payment-related emails for seated events are only sent to the newly booked participant, instead of all previous attendees. This solves the issue where users who had already paid were receiving duplicate and unnecessary payment reminders.

Why no toggle was added?

The original issue mentioned adding a toggle to disable group-wide emails:

"Have a toggle to disable sending emails to the entire group."

That toggle was likely suggested as a workaround. However, since this PR completely prevents the incorrect behavior by default, such a toggle is no longer needed.

In fact, adding a toggle now would reintroduce broken behavior. Sending payment emails to all attendees is confusing and incorrect, and should not be an optional behavior.

Visual Demo

Before:

All attendees (even those who had already paid) received a payment request email when someone booked.

After (with this PR):

Only the attendee who made the new booking receives a payment email.

(Screenshots or recording can be added here)

Checklist

I have self-reviewed the code.
I have verified the fix locally using seated events and email inspection.
No documentation changes are required (N/A).
This PR does not introduce new warnings or regressions.

🧪 How to test this

Create a seated event (with at least 2 seats).
Book a seat as User A.
- ✅ User A should get the payment email.
Book another seat as User B.
- ✅ Only User B gets a new payment email.
- ❌ User A should not receive another email.
Try with more attendees and check that only the most recent booking gets the payment link.

Fixes calcom#22524. Prevents previously booked users from receiving duplicate payment emails.

coderabbitai · 2025-07-16T13:01:30Z

Walkthrough

The implementation of the afterPayment method in the PaymentService class was updated to ensure that payment-related email and SMS notifications are sent only to the attendee whose email matches the booking user's email. The method now filters the event's attendees list to find the matching attendee and, if found, sends the awaiting payment notification exclusively to that individual. If no matching attendee is found, the method logs a warning and exits without sending notifications. No changes were made to the method's signature or other public interfaces.

Assessment against linked issues

Objective	Addressed	Explanation
Payment emails should only be sent to the intended user, not all participants (#22524)	✅
Add a toggle to disable sending emails to the entire group (#22524)	❌	No toggle or configuration option was introduced to control group email sending behavior.

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes were found.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

packages/app-store/stripepayment/lib/PaymentService.ts

Oops! Something went wrong! :(

ESLint: 8.57.1

ESLint couldn't find the plugin "eslint-plugin-playwright".

(The package "eslint-plugin-playwright" was not found when loaded as a Node module from the directory "".)

It's likely that the plugin isn't installed correctly. Try reinstalling by running the following:

npm install eslint-plugin-playwright@latest --save-dev

The plugin "eslint-plugin-playwright" was referenced from the config file in ".eslintrc.js".

If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between df30f5c and 1d73ad0.

📒 Files selected for processing (1)

packages/app-store/stripepayment/lib/PaymentService.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

GitHub Check: Install dependencies / Yarn install & cache
GitHub Check: Security Check

🔇 Additional comments (2)

packages/app-store/stripepayment/lib/PaymentService.ts (2)

373-379: LGTM: Proper attendee filtering with appropriate error handling.

The implementation correctly finds the attendee matching the booking user's email and handles the case where no match is found with appropriate logging and early return.

381-385: LGTM: Effective solution to prevent duplicate payment emails.

The filtered attendees array ensures that payment notifications are sent exclusively to the newly booked participant, which directly addresses the PR objective of preventing duplicate emails to all seated event attendees.

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vercel · 2025-07-16T13:01:38Z

@DarshanKumarA is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

graphite-app · 2025-07-16T13:05:11Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/16/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (07/16/25)

1 label was added to this PR based on Keith Williams's automation.

github-actions · 2025-07-31T00:27:17Z

This PR is being marked as stale due to inactivity.

kart1ka · 2025-08-04T03:54:59Z

Hi @DarshanKumarA, Thanks for the pr. Could you pls add a loom video showing your fix?

DarshanKumarA · 2025-08-04T05:26:44Z

Hi @DarshanKumarA, Thanks for the pr. Could you pls add a loom video showing your fix?

Yes I'm on it, will share the video by noon

kart1ka · 2025-08-11T17:24:28Z

@DarshanKumarA Could you pls share a loom video of your fix?

github-actions · 2025-08-26T00:24:50Z

This PR is being marked as stale due to inactivity.

github-actions · 2025-09-02T12:47:16Z

E2E results are ready!

Workflow #74934.1 latest results

fix(payment): only send payment email to booking user in seated events

1d73ad0

Fixes calcom#22524. Prevents previously booked users from receiving duplicate payment emails.

graphite-app bot requested a review from a team July 16, 2025 13:01

graphite-app bot added the community Created by Linear-GitHub Sync label Jul 16, 2025

github-actions bot added emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email seats area: seats, guest meetings, multiple people 🐛 bug Something isn't working labels Jul 16, 2025

dosubot bot added the payments Created by Linear-GitHub Sync label Jul 16, 2025

anikdhabal added the Medium priority Created by Linear-GitHub Sync label Jul 16, 2025

github-actions bot added the Stale label Jul 31, 2025

Merge branch 'main' into fix/seated-payment-clean

2dca464

github-actions bot removed the Stale label Aug 5, 2025

Merge branch 'main' into fix/seated-payment-clean

5d2ac53

github-actions bot added the Stale label Aug 26, 2025

kart1ka added 2 commits August 27, 2025 20:59

Merge branch 'main' into fix/seated-payment-clean

d621e72

Merge branch 'main' into fix/seated-payment-clean

ad2a523

github-actions bot removed the Stale label Aug 29, 2025

jaykayenn mentioned this pull request Aug 29, 2025

Seated events will send emails to everyone, including payment emails. #22524

Closed

anikdhabal added 4 commits September 2, 2025 17:24

Update PaymentService.ts

5668d24

Merge branch 'main' into fix/seated-payment-clean

44bcb91

Update PaymentService.ts

934fe6d

Update PaymentService.ts

e14cba2

anikdhabal approved these changes Sep 2, 2025

View reviewed changes

graphite-app bot added the ready-for-e2e label Sep 2, 2025

anikdhabal enabled auto-merge (squash) September 2, 2025 12:00

Merge branch 'main' into fix/seated-payment-clean

bc55bbd

anikdhabal merged commit 6cd4f1f into calcom:main Sep 2, 2025
31 of 35 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(payment): only send payment email to booking user in seated events #22558

fix(payment): only send payment email to booking user in seated events #22558

DarshanKumarA commented Jul 16, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

vercel bot commented Jul 16, 2025

Uh oh!

graphite-app bot commented Jul 16, 2025

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

kart1ka commented Aug 4, 2025

Uh oh!

DarshanKumarA commented Aug 4, 2025

Uh oh!

kart1ka commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 26, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 2, 2025

Uh oh!

Uh oh!

fix(payment): only send payment email to booking user in seated events #22558

fix(payment): only send payment email to booking user in seated events #22558

Conversation

DarshanKumarA commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fixes #22524 – Prevents duplicate payment emails to all users and only send payment email to booking user in seated events

What does this PR do?

Why no toggle was added?

Visual Demo

Checklist

🧪 How to test this

Uh oh!

coderabbitai bot commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

vercel bot commented Jul 16, 2025

Uh oh!

graphite-app bot commented Jul 16, 2025

Graphite Automations

Uh oh!

github-actions bot commented Jul 31, 2025

Uh oh!

kart1ka commented Aug 4, 2025

Uh oh!

DarshanKumarA commented Aug 4, 2025

Uh oh!

kart1ka commented Aug 11, 2025

Uh oh!

github-actions bot commented Aug 26, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 2, 2025

E2E results are ready!

Uh oh!

Uh oh!

DarshanKumarA commented Jul 16, 2025 •

edited

Loading

coderabbitai bot commented Jul 16, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)