feat: add race condition test for calendar-cache-serve booking flow #22401

zomars · 2025-07-11T03:11:56Z

fix for revert #22400

Reproduces double-booking when two guests book same timeslot 1-2s apart
Enables both calendar-cache and calendar-cache-serve feature flags
Uses parallel browser contexts to simulate concurrent booking attempts
Verifies both bookings succeed and create double-booking scenario

What does this PR do?

Fixes #XXXX (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

Show screen recordings of the issue or feature.
Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

Add side-by-side screenshots of the original and updated change.
Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

- Reproduces double-booking when two guests book same timeslot 1-2s apart - Enables both calendar-cache and calendar-cache-serve feature flags - Uses parallel browser contexts to simulate concurrent booking attempts - Verifies both bookings succeed and create double-booking scenario Co-Authored-By: zomars@cal.com <zomars@me.com>

- Change page.waitForTimeout(1500) to use correct page context - Fix timeslot selection to ensure both contexts book same slot - Remove incorrect host assertion and add logging to demonstrate race condition - Test now successfully reproduces double-booking bug locally - Fixes 'end of central directory record signature not found' error Co-Authored-By: zomars@cal.com <zomars@me.com>

…ition

Signed-off-by: Omar López <zomars@me.com>

vercel · 2025-07-11T03:11:59Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		Jul 13, 2025 2:43pm
cal-eu	⬜️ Ignored (Inspect)	Visit Preview		Jul 13, 2025 2:43pm

delve-auditor · 2025-07-11T03:13:44Z

✅ No security or compliance issues detected. Reviewed everything up to 8825052.

Security Overview

🔎 Scanned files: 1 changed file(s)

Detected Code Changes

Change Type	Relevant files
Enhancement	► booking-race-condition.e2e.ts Add test suite for concurrent booking behavior

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

cubic-dev-ai

cubic found 1 issue across 1 file. Review it in cubic.dev

_{React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.}

cubic-dev-ai · 2025-07-11T03:14:55Z

apps/web/playwright/booking-race-condition.e2e.ts

+    await mockGoogleCalendarAPI(page2);
+
+    // Navigate to booking page
+    await page1.goto(`/org/${org.slug}/${team.slug}/${teamEvent.slug}`);


Rule violated: E2E Tests Best Practices

Missing expect(page).toHaveurl("") after navigation violates the E2E test guideline to fail fast on unexpected redirects.

graphite-app · 2025-07-11T03:15:11Z

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (07/11/25)

1 reviewer was added to this PR based on Keith Williams's automation.

…ition

github-actions · 2025-07-11T04:02:31Z

E2E results are ready!

Workflow #67344.1 latest results

…ition

anikdhabal

Looks good

- Recreate race condition test from PR #22401 for calendar-cache-serve booking flow - Replace hardcoded TEST_DATE with dynamic first available slot selection - Use getDynamicBookingDate function to select first available day dynamically - Prevent test flakiness by avoiding hardcoded tomorrow dates - Test validates concurrent booking prevention and cache functionality Co-Authored-By: anik@cal.com <adhabal2002@gmail.com>

…22401) Co-authored-by: zomars@cal.com <zomars@me.com> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

* feat: add race condition test with dynamic date selection - Recreate race condition test from PR #22401 for calendar-cache-serve booking flow - Replace hardcoded TEST_DATE with dynamic first available slot selection - Use getDynamicBookingDate function to select first available day dynamically - Prevent test flakiness by avoiding hardcoded tomorrow dates - Test validates concurrent booking prevention and cache functionality Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * fix: replace dynamic date selection with fixed future date for efficiency Co-Authored-By: anik@cal.com <adhabal2002@gmail.com> * Revert "fix: replace dynamic date selection with fixed future date for efficiency" This reverts commit b4b7d35. --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration bot and others added 16 commits June 30, 2025 22:51

Update booking-race-condition.e2e.ts

cea402d

Update booking-race-condition.e2e.ts

606b866

Update booking-race-condition.e2e.ts

ccab6ed

Update booking-race-condition.e2e.ts

3055c73

Create scratchpad.md

a80063e

Merge branch 'main' into devin/1751323069-reproduce-booking-race-cond…

5b26a50

…ition

Merge branch 'main' into devin/1751323069-reproduce-booking-race-cond…

a2659b6

…ition

Update booking-race-condition.e2e.ts

9fc81aa

Delete scratchpad.md

b80b073

Update booking-race-condition.e2e.ts

9704ee7

Merge branch 'main' into devin/1751323069-reproduce-booking-race-cond…

6ddcd96

…ition

Update booking-race-condition.e2e.ts

e92a959

Update booking-race-condition.e2e.ts

dd46fa0

fix: dyanmix dates for e2e test

be4a307

Signed-off-by: Omar López <zomars@me.com>

graphite-app bot requested a review from a team July 11, 2025 03:12

keithwillcode added core area: core, team members only foundation labels Jul 11, 2025

zomars added the ready-for-e2e label Jul 11, 2025

dosubot bot added automated-tests area: unit tests, e2e tests, playwright bookings area: bookings, availability, timezones, double booking labels Jul 11, 2025

cubic-dev-ai bot reviewed Jul 11, 2025

View reviewed changes

vercel bot deployed to Preview – dev July 11, 2025 03:29 View deployment

Merge branch 'main' into devin/1751323069-reproduce-booking-race-cond…

6188712

…ition

zomars enabled auto-merge (squash) July 11, 2025 03:40

vercel bot deployed to Preview – dev July 11, 2025 03:59 View deployment

anikdhabal self-assigned this Jul 11, 2025

Merge branch 'main' into devin/1751323069-reproduce-booking-race-cond…

ef74e41

…ition

vercel bot deployed to Preview – dev July 11, 2025 18:24 View deployment

vercel bot temporarily deployed to Preview – api July 13, 2025 12:07 Inactive

update

9298daf

vercel bot deployed to Preview – dev July 13, 2025 12:24 View deployment

vercel bot temporarily deployed to Preview – api July 13, 2025 13:32 Inactive

chnages

9342447

vercel bot deployed to Preview – dev July 13, 2025 13:48 View deployment

Merge branch 'main' into devin/1751323069-reproduce-booking-race-cond…

8825052

…ition

vercel bot deployed to Preview – dev July 13, 2025 15:02 View deployment

anikdhabal approved these changes Jul 13, 2025

View reviewed changes

zomars merged commit dfe997d into main Jul 13, 2025
38 checks passed

zomars deleted the devin/1751323069-reproduce-booking-race-condition branch July 13, 2025 15:07

anikdhabal removed their assignment Jul 13, 2025

zomars mentioned this pull request Jul 14, 2025

Revert "feat: add race condition test for calendar-cache-serve booking flow" #22507

Merged

devin-ai-integration bot mentioned this pull request Jul 15, 2025

feat: add race condition test with dynamic date selection #22533

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add race condition test for calendar-cache-serve booking flow #22401

feat: add race condition test for calendar-cache-serve booking flow #22401

Uh oh!

zomars commented Jul 11, 2025 •

edited

Loading

Uh oh!

vercel bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

delve-auditor bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

cubic-dev-ai bot Jul 11, 2025

Uh oh!

graphite-app bot commented Jul 11, 2025

Uh oh!

github-actions bot commented Jul 11, 2025 •

edited

Loading

Uh oh!

anikdhabal left a comment

Uh oh!

Uh oh!

Uh oh!

feat: add race condition test for calendar-cache-serve booking flow #22401

feat: add race condition test for calendar-cache-serve booking flow #22401

Uh oh!

Conversation

zomars commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Visual Demo (For contributors especially)

Video Demo (if applicable):

Image Demo (if applicable):

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

Uh oh!

vercel bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

delve-auditor bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Jul 11, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Jul 11, 2025

Graphite Automations

Uh oh!

github-actions bot commented Jul 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

anikdhabal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

zomars commented Jul 11, 2025 •

edited

Loading

vercel bot commented Jul 11, 2025 •

edited

Loading

delve-auditor bot commented Jul 11, 2025 •

edited

Loading

github-actions bot commented Jul 11, 2025 •

edited

Loading