feat: Enhance private link expiration with usage and date limits #20118
Conversation
|
@retrogtx is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (03/17/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (03/17/25)1 label was added to this PR based on Keith Williams's automation. |
|
@retrogtx You beat me on this :D. I was almost done with the implementation, i had implemented it differently as in instead of dropdown, just provided the max usage and expiry date field as input and then based on the values add the checks for expiry and also show the link expiry error message below the link. Anyways good job! |
|
hey @asadath1395 thanks for trying, there are many other issues lying around along with bounties that might interest you thank you again 🫡 |
E2E results are ready! |
There was a problem hiding this comment.
Clean work! 🙏
There's a NIT though, I'd rather have the expired links showing still and shown as expired instead of turning off the private links automatically upon expiration. Also, it would be better to have a visual representation of how many usages are left for the private link (or when expiration is due) for example.
Otherwise, there is a great overhead in support waiting to crash!
…time updates - Added usageCount to PrivateLinkWithOptions type for tracking link usage. - Updated getServerSideProps to select hashed link data including usageCount. - Refactored MultiplePrivateLinksController to fetch and display real-time usage data for links. - Implemented cache invalidation on component mount to ensure fresh data retrieval. - Improved link description logic to reflect usage limits and expiration status accurately.
|
🫡 @alishaz-polymath everything's done |
|
@retrogtx Can you please close down the mrge comments which are resolved/unnecessary? |
|
Now it is not expiring the single-use link. I could use it to book twice, and it's still not expired. |
|
@alishaz-polymath bossman 🫡 |
|
Closing in favor of #22304 |
What does this PR do?
https://www.loom.com/share/70bf41049d7a4e36b8f5a894e8647739?sid=3a37fce8-5c18-441b-8640-bbc6e202a661
Mandatory Tasks (DO NOT REMOVE)