Skip to content

perf: Maps for app categories #19771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 94 commits into from
Closed

perf: Maps for app categories #19771

wants to merge 94 commits into from

Conversation

keithwillcode
Copy link
Contributor

What does this PR do?

Similar to what was done in #19718, we now have a smaller map of payment apps to avoid importing the entire app store for just a few payment apps.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • N/A - I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Ensure payment apps are still working

@keithwillcode keithwillcode self-assigned this Mar 5, 2025
@keithwillcode keithwillcode added core area: core, team members only foundation labels Mar 5, 2025
@keithwillcode keithwillcode changed the title perf: Add payment apps map perf: Maps for app categories Mar 5, 2025
@vercel Vercel
Copy link

vercel bot commented Mar 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal-com-ui-playground ❌ Failed (Inspect) Jul 17, 2025 7:11pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2025 7:11pm
cal-eu ⬜️ Ignored (Inspect) Jul 17, 2025 7:11pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Jul 17, 2025 7:11pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 5, 2025 •
edited
Loading

E2E results are ready!

devin-ai-integration bot and others added 2 commits April 8, 2025 16:03
@devin-ai-integration
fix: update MockCalendarService to use calEvent parameter instead of …
5b3a6a5 
…event

Co-Authored-By: keith@cal.com <keith@cal.com>
@devin-ai-integration
fix: remove require statements in bookingScenario.ts
1e34757 
Co-Authored-By: keith@cal.com <keith@cal.com>
devin-ai-integration bot and others added 3 commits April 8, 2025 17:57
@devin-ai-integration
fix: update mock functions to properly track method calls
70eedd8 
Co-Authored-By: keith@cal.com <keith@cal.com>
@devin-ai-integration
fix: update mock implementations to track method calls and fix type i…
a86e8a9 
…ssues

Co-Authored-By: keith@cal.com <keith@cal.com>
@devin-ai-integration
fix: update interface definitions to make externalCalendarId optional
6e723cb 
Co-Authored-By: keith@cal.com <keith@cal.com>
@github-actions GitHub Actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added Stale and removed Stale labels Apr 23, 2025
@devin-ai-integration @keithwillcode
fix: resolve TypeScript type errors in booking fields transformer and…
7a4205d 
… location handling

- Fix LocationDefaultFieldInput_2024_06_14 type compatibility issues with defensive property checks
- Add missing createdAt/updatedAt fields to destinationCalendar objects in buildCalEventFromBooking
- Update editLocation handler to properly handle user destinationCalendar timestamps
- Ensure type-safe transformations for booking field inputs with optional properties

Co-Authored-By: keith@cal.com <keithwillcode@gmail.com>
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 17, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@keithwillcode
Copy link
Contributor Author

Closing for now since we couldn't get the mocking sorted. We know this implementation tremendously helps so will continue exploring with #22630 and #22450

@keithwillcode keithwillcode mentioned this pull request Aug 14, 2025
Open
This was referenced Aug 21, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@zomars zomars zomars left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@keithwillcode keithwillcode

Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar core area: core, team members only foundation performance area: performance, page load, slow, slow endpoints, loading screen, unresponsive ready-for-e2e self-hosted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@keithwillcode @zomars @joeauyeung @hbjORbj @sean-brydon