feat: to enable optimized slots #16579

vijayraghav-io · 2024-09-10T19:08:44Z

What does this PR do?

Fixes [CAL-4303] Optimized schedules #16575
Fixes CAL-4303

For the sake of demo video, availability is adjusted to simulate busy time as per examples in issue description. It should work same even with calendar busy times.

https://www.loom.com/share/8247ea087bae4aa497c48853bb2e3f8d?sid=33a96f51-1548-43d7-9b37-815d90ecc6b8

Video with calendar busy times (as per example)

https://www.loom.com/share/a9a04ee012134f31b4a5a0dfa6b2072e?sid=a4a98b11-263d-4799-875e-fe46b45ab8bf

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
-N/A - I have added a Docs issue here if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

vercel · 2024-09-10T19:08:50Z

@vijayraghav-io is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

graphite-app · 2024-09-10T19:20:10Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (09/10/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (09/10/24)

1 label was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (09/12/24)

1 reviewer was added to this PR based on Keith Williams's automation.

vijayraghav-io · 2024-09-11T03:17:08Z

packages/lib/slots.ts

+    slotStartTime =
+      slotStartTime.minute() % interval !== 0
+        ? showOptimizedSlots
+          ? slotStartTime.add(rangeEnd.diff(slotStartTime, "minutes") % interval, "minute")


This ensures within a time range, always maximum available (optimum) slots are shown (without loss of any slot) And also Start of the Hour is respected.
Also , this happens only if user availability starts in minutes , say 10:10 , 10:05 (instead of 10:00 normally) and user has chosen to optimize.
For all other scenarios, the existing behaviour applies and i understand that is expected.

github-actions · 2024-09-11T12:41:53Z

E2E results are ready!

Workflow #71754.2 latest results

…6575_optimizedSchedules

Amit91848

Thanks for the PR @vijayraghav-io 🙌.
Haven't tested it completely yet, but code wise looks good. Can you add tests to ensure this works and won't break in the future.

vijayraghav-io · 2024-09-11T15:05:00Z

Thanks for the PR @vijayraghav-io 🙌. Haven't tested it completely yet, but code wise looks good. Can you add tests to ensure this works and won't break in the future.

Thank you! @Amit91848 , sure will add tests.

…6575_optimizedSchedules

vijayraghav-io · 2024-09-12T12:58:16Z

@Amit91848, added tests.

CarinaWolli

This availability:

Shows the following slots:

But should be:
8:00, 9:00, 10:00, 11:00, 12:00, 13:00, 14:00

vijayraghav-io · 2024-09-12T16:00:06Z

This availability:

@CarinaWolli , handled this edge case. Also added a test case for this.

To explain the implementation -
A increment is added to the slotStartTime to adjust to be Start Of the hour,
if this increment exceeds the next Start of the hour, a condition is added to Not exceed the Start of the hour.
This should cover all cases.

vijayraghav-io · 2024-09-12T16:23:08Z

packages/lib/slots.ts

+          ? rangeEnd.diff(slotStartTime, "minutes") % interval > interval - slotStartTime.minute()
+            ? slotStartTime.add(interval - slotStartTime.minute(), "minute")
+            : slotStartTime.add(rangeEnd.diff(slotStartTime, "minutes") % interval, "minute")


rangeEnd.diff(slotStartTime, "minutes") % interval - gives the remaining grace minutes available for adjustment, after consuming maximum possible slots.

Condition rangeEnd.diff(slotStartTime, "minutes") % interval > interval - slotStartTime.minute() -
After adding this grace (or free) minutes available for adjustment to slotStartTime, if result exceeds the 'next start of the hour , it is adjusted to 'start of the hour

delve-auditor · 2025-07-22T14:13:06Z

✅ No security or compliance issues detected. Reviewed everything up to 7accaf7.

Security Overview

🔎 Scanned files: 16 changed file(s)

Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

Devanshusharma2005

Great pr @vijayraghav-io . Can you please address the typecheck issue failing.

vijayraghav-io · 2025-07-29T09:28:28Z

Great pr @vijayraghav-io . Can you please address the typecheck issue failing.

Thank you! 🙏 , sure will address.

…tlook_cache

vijayraghav-io · 2025-07-29T12:41:43Z

@Devanshusharma2005 all checks are passing

CarinaWolli · 2025-08-12T08:27:47Z

@emrysal for review, it's looking good from my side 🙏

volnei

LGTM

feature to enable optimized slots

d75c2ad

github-actions bot added ❗️ migrations contains migration files ✨ feature New feature or request labels Sep 10, 2024

dosubot bot added the event-types area: event types, event-types label Sep 10, 2024

graphite-app bot added the community Created by Linear-GitHub Sync label Sep 10, 2024

graphite-app bot requested a review from a team September 10, 2024 19:15

vijayraghav-io added 3 commits September 11, 2024 00:59

type check (was not caught running locally)

bf62515

update for typechecks

bf24c7e

update for type checks

2f59011

vijayraghav-io commented Sep 11, 2024

View reviewed changes

initialize form

7d728cb

keithwillcode added the ready-for-e2e label Sep 11, 2024

Merge branch 'main' of https://github.com/calcom/cal.com into feat_#1…

c1c1828

…6575_optimizedSchedules

Amit91848 requested changes Sep 11, 2024

View reviewed changes

vijayraghav-io added 3 commits September 12, 2024 15:35

update slots test for showOptimizedSlots

62e127e

Merge branch 'main' of https://github.com/calcom/cal.com into feat_#1…

5a85a1d

…6575_optimizedSchedules

added some more tests

d5ac319

CarinaWolli requested changes Sep 12, 2024

View reviewed changes

CarinaWolli added the high-risk Requires approval by Foundation team label Sep 12, 2024

graphite-app bot requested a review from a team September 12, 2024 14:12

vijayraghav-io added 2 commits September 12, 2024 20:05

handled edge case

7474f01

added test for edge case

4217e7b

generalized condition

7dcbd53

vijayraghav-io commented Sep 12, 2024

View reviewed changes

dosubot bot modified the milestone: v5.6 Jul 16, 2025

CarinaWolli previously approved these changes Jul 16, 2025

View reviewed changes

CarinaWolli requested a review from emrysal July 16, 2025 07:59

coderabbitai bot mentioned this pull request Jul 17, 2025

feat: add Flappy Bird game feature #22297

Open

3 tasks

merge main

7accaf7

CarinaWolli dismissed their stale review via 7accaf7 July 22, 2025 14:11

CarinaWolli previously approved these changes Jul 22, 2025

View reviewed changes

vercel bot deployed to Preview – dev July 22, 2025 14:20 View deployment

This was referenced Jul 23, 2025

feat: Add option to disable autofill on booking page #22687

Open

feat: add toggle to disable recording download email for guests #22259

Draft

chore: add auto recording #22723

Merged

feat: disable recording emails for guests #22457

Closed

Merge branch 'main' into feat_#16575_optimizedSchedules

fa48667

Devanshusharma2005 requested changes Jul 29, 2025

View reviewed changes

vijayraghav-io added 2 commits July 29, 2025 15:37

Merge branch 'main' of https://github.com/calcom/cal.com into feat_ou…

a120cfc

…tlook_cache

update for typecheck due to latest changes

72b014b

vijayraghav-io dismissed CarinaWolli’s stale review via 72b014b July 29, 2025 11:59

vijayraghav-io requested a review from Devanshusharma2005 July 29, 2025 12:41

vijayraghav-io requested a review from CarinaWolli July 29, 2025 13:27

CarinaWolli added High priority Created by Linear-GitHub Sync and removed Medium priority Created by Linear-GitHub Sync labels Aug 12, 2025

Merge branch 'main' into feat_#16575_optimizedSchedules

503bf8c

volnei approved these changes Aug 13, 2025

View reviewed changes

dosubot bot modified the milestones: v5.6, v5.7 Aug 18, 2025

feat: to enable optimized slots #16579

Are you sure you want to change the base?

feat: to enable optimized slots #16579

Conversation

vijayraghav-io commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

Uh oh!

vercel bot commented Sep 10, 2024

Uh oh!

graphite-app bot commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Graphite Automations

Uh oh!

vijayraghav-io Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Sep 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E results are ready!

Uh oh!

Amit91848 left a comment

Choose a reason for hiding this comment

Uh oh!

vijayraghav-io commented Sep 11, 2024

Uh oh!

vijayraghav-io commented Sep 12, 2024

Uh oh!

CarinaWolli left a comment

Choose a reason for hiding this comment

Uh oh!

vijayraghav-io commented Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vijayraghav-io Sep 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

delve-auditor bot commented Jul 22, 2025

Uh oh!

Devanshusharma2005 left a comment

Choose a reason for hiding this comment

Uh oh!

vijayraghav-io commented Jul 29, 2025

Uh oh!

vijayraghav-io commented Jul 29, 2025

Uh oh!

CarinaWolli commented Aug 12, 2025

Uh oh!

volnei left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

vijayraghav-io commented Sep 10, 2024 •

edited

Loading

graphite-app bot commented Sep 10, 2024 •

edited

Loading

github-actions bot commented Sep 11, 2024 •

edited

Loading

vijayraghav-io commented Sep 12, 2024 •

edited

Loading

vijayraghav-io Sep 12, 2024 •

edited

Loading