fix: Autodetection of time zone only updated default time zone #15392
Conversation
|
@Amit91848 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add community label" took an action on this PR • (06/10/24)1 label was added to this PR based on Keith Williams's automation. "Add consumer team as reviewer" took an action on this PR • (06/10/24)1 reviewer was added to this PR based on Keith Williams's automation. |
|
This PR is being marked as stale due to inactivity. |
|
I think this messed up my (and I am sure all other user's) whole Availability. This overwrote my saved timezone from Europe/Budapest to America/Sao Paulo. And my booking page shows my whole calendar free for normal looking appointments, but the real appointments were in America/Sao Paolo timezone, so customers booked appointments for midnight instead of afternoon. And customers thought it is an appointment for afternoon, because it looked like afternoon.... |
|
OK, I saved for Europe/Budapest, and now after 10 minutes it is America/Guatemala. Please rollback to 4.2.3 |
| id: { | ||
| in: input.availabilityIds, | ||
| }, |
There was a problem hiding this comment.
This is a very dangerous change. We don't validate availabilityIds are present since this field is optional. This will trigger an update of ALL schedules. Already affected production.
There was a problem hiding this comment.
There was a problem hiding this comment.
Have to be honest. This seems like bad default behavior by prisma. Will reach out to them for insights
There was a problem hiding this comment.
My mistake 😥😫! Will keep it in mind next time
There was a problem hiding this comment.
Opened #15721 to prevent this from happening in the future
* commit '0dd3b2562458522ad002b4ea967e2b10855a4ab6': (130 commits) chore: v4.2.5 (calcom#15735) fix: api v2 unit tests (calcom#15733) fix: event type back button (calcom#15722) fix: remove console.log and tsignore apiv2 (calcom#15732) fix: api-v2 controllers e2e tests (calcom#15724) fix: Text in Embed Code Visibility Fixed (calcom#15711) chore: sort calendar crendentials in event manager (calcom#15448) chore: cache org guard and fix roles guard apiv2 (calcom#15719) Revert "fix: Autodetection of time zone only updated default time zone (calcom#15392)" (calcom#15720) feat: add POST end point to mark calls as no-shows (calcom#15690) chore: add i18n to atoms (calcom#15698) fix: set conferencing apps as default (calcom#15376) fix: disable google-meet in user onboarding if google-calendar is not installed (calcom#15702) fix: Rescheduling email when there is broken calendar integration (calcom#15669) chore: v4.2.4 (calcom#15703) fix: 404s becoming 500s (calcom#15696) fix: delete reserved slot on booker unmount (calcom#15700) chore: add caching apiv2 roles guard (calcom#15694) refactor: handleNewBooking calcom#3 (calcom#15612) fix: incorrect booking seats full error on collective seated event (calcom#15602) ... # Conflicts: # packages/emails/templates/attendee-request-email.ts # packages/emails/templates/attendee-was-requested-to-reschedule-email.ts # packages/emails/templates/organizer-cancelled-email.ts # packages/emails/templates/organizer-location-change-email.ts # packages/emails/templates/organizer-payment-refund-failed-email.ts # packages/emails/templates/organizer-request-email.ts # packages/emails/templates/organizer-request-reminder-email.ts # packages/emails/templates/organizer-requested-to-reschedule-email.ts # packages/emails/templates/organizer-rescheduled-email.ts # packages/emails/templates/organizer-scheduled-email.ts
…m#15392) * fix: Autodetection of time zone only updated default time zone * fix: description text --------- Co-authored-by: sean-brydon <55134778+sean-brydon@users.noreply.github.com>
calcom#15392)" (calcom#15720) This reverts commit 285d1ec.
What does this PR do?
Recording.2024-06-10.173746.mp4
Mandatory Tasks (DO NOT REMOVE)