Skip to content

Update Test Expecting Select Column Values To Be Unique Within Record #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 16, 2024
Merged

Update Test Expecting Select Column Values To Be Unique Within Record #300

merged 1 commit into from
Feb 16, 2024

Conversation

bkimjin
Copy link
Contributor

@bkimjin bkimjin commented Feb 16, 2024

Issue this PR Addresses/Closes

Closes #299

Summary of Changes

Adds md5 around column in unpivoted_columns.

Why Do We Need These Changes

This will allow for different data types to be used within the test.

Reviewers

@clausherther

@clausherther
Copy link
Contributor

Good catch!

clausherther
clausherther approved these changes Feb 16, 2024
View reviewed changes
Copy link
Contributor

@clausherther clausherther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@clausherther clausherther merged commit f645ef3 into calogica:main Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clausherther clausherther clausherther approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] expect_select_column_values_to_be_unique_within_record Doesn't Allow for Different Data Types
2 participants
@bkimjin @clausherther