Fix regression in model trainer #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
gabe-l-hart
reviewed
Sep 11, 2024
| @@ -44,6 +44,9 @@ def __init__(self, *args, **kwargs): | |||
| kwargs["future_name"] = kwargs["trainer_name"] | |||
| if "training_id" in kwargs: | |||
| kwargs["future_id"] = kwargs["training_id"] | |||
| # If save path is provided then add it as a property | |||
There was a problem hiding this comment.
I think we might want to do this no matter what and just assign it to None given that the log line will fire on any trainer?
There was a problem hiding this comment.
That's a good point. The save_path should almost always be included in future construction but that does rely on the trainer implementations
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
gabe-l-hart
approved these changes
Sep 11, 2024
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This Pr fixes a regression with caikit 0.27 where the save_path was no longer included in the model trainer future base.
Special notes for your reviewer:
If applicable: