Expose GRPC Concurrency Option and Update Retry #765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Honaker <Michael.Honaker@ibm.com>
eec7100 to
b7b4c96
Compare
|
@gabe-l-hart not sure if this one needs new tests. It's just exposing an option of the underlying grpc server. |
gabe-l-hart
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Looks good according to the docs: https://grpc.github.io/grpc/python/grpc.html#grpc.server
| @@ -84,6 +84,7 @@ def __init__( | |||
| thread_pool=self.thread_pool, | |||
| interceptors=(PROMETHEUS_METRICS_INTERCEPTOR,), | |||
| options=(self.config.runtime.grpc.options or {}).items(), | |||
| maximum_concurrent_rpcs=self.config.runtime.grpc.maximum_concurrent_rpcs, | |||
There was a problem hiding this comment.
Interesting that this does not go into the options arg? Assuming this is correct, then this looks good to me
There was a problem hiding this comment.
Yeah its kinda annoying. TBH I thought this was an option for the longest time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR exposes another GRPC server option to allow for greater customization of deployment runtimes. This also updates the remote module connection to better retry requests when people use the above option.
Special notes for your reviewer:
If applicable: