Add count option to migrate #2360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
1b583fb to
a0aaaba
Compare
Signed-off-by: Matthew Peveler <matt.peveler@gmail.com>
dereuromark
reviewed
Jul 17, 2025
| @@ -38,15 +38,17 @@ protected function configure(): void | |||
| $this->setDescription('Migrate the database') | |||
| ->addOption('--target', '-t', InputOption::VALUE_REQUIRED, 'The version number to migrate to') | |||
| ->addOption('--date', '-d', InputOption::VALUE_REQUIRED, 'The date to migrate to') | |||
| ->addOption('--count', '-k', InputOption::VALUE_REQUIRED, 'The number of migrations to run') | |||
There was a problem hiding this comment.
wouldnt -n be better here than k?
There was a problem hiding this comment.
-n is taken up by builtin option that comes from symfony console:
-n, --no-interaction Do not ask any interactive question
This was referenced Jul 17, 2025
|
@MasterOdin Maybe you want to enable this for phinx asap and we can do one full release with all the API consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half does #258
PR adds a new
-k/--countoption to the migrate command which allows for running arbitrary number of migrations, without relying on target or date. Decided to use the-kshorthand as-c,-n, and-twere already used, and it can stand for "kount" which I feel like other tools have done (vs-oas suggested in the issue, which feels more arbitrary).I decided to deal with rollback in a follow-up PR as there's a workaround for this functionality there, which is just running the rollback command however many times you need.