Skip to content

fix: removeOption() does not clear _shortOptions in ConsoleOptionParser #18376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: removeOption() does not clear _shortOptions in ConsoleOptionParser #18376

wants to merge 1 commit into from

Conversation

s-nakajima
Copy link
Contributor

@dereuromark
Copy link
Member

We should add a test case

@dereuromark dereuromark mentioned this pull request Apr 23, 2025
Merged
@dereuromark
Copy link
Member

Thank you, I opened #18377 with a test case so that once we throw an error here instead of deprecation, we can see that it is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s-nakajima @dereuromark