Fixed up chaotic addClass() docblock types. #18360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADmad
reviewed
Apr 19, 2025
| @@ -346,7 +346,7 @@ protected function _formatAttribute(string $key, mixed $value, bool $escape = tr | |||
| /** | |||
| * Adds a class and returns a unique list either in array or space separated | |||
| * | |||
| * @param mixed $input The array or string to add the class to | |||
| * @param array<string, mixed>|string|null $input The array or string to add the class to | |||
There was a problem hiding this comment.
The actual types include false too.
There was a problem hiding this comment.
Not documented and untested apparently :) I wonder if we should add as "expected inputs".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future maybe we can split those based on array vs string.
And the input type wouldnt need to be mixed IMO, but array|string.