Fix up template annotation. #18351
Merged
Fix up template annotation. #18351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 18, 2025
ADmad
reviewed
Apr 18, 2025
| @@ -155,7 +155,7 @@ | |||
| * | |||
| * @see \Cake\Event\EventManager for reference on the events system. | |||
| * @link https://book.cakephp.org/5/en/orm/table-objects.html#event-list | |||
| * @template TBehaviors of array<string, \Cake\ORM\Behavior> | |||
| * @template TBehaviors of array<string, \Cake\ORM\Behavior> = array{} | |||
There was a problem hiding this comment.
Haven't seen such syntax anywhere. Can you point to some doc?
There was a problem hiding this comment.
See the refered phpstan link where he himself explains it.
I just tested it and it works, also added it to my extended models
dereuromark/cakephp-shim@7baa2a1
As apparently templates are not properly extended, so those need to be defined on every extension level
But then my latest change dereuromark/cakephp-ide-helper@ea3f166
makes it fully work :)
ADmad
approved these changes
Apr 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow #18323
This defaulting seems like a good idea to prevent everyone having to do
dereuromark/cakephp-ide-helper@c2a732f
everywhere
Refs phpstan/phpstan#12868 (reply in thread)