Fix task priority assigner for history queue v2 #7131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+132
to
+133
| // QueueTypeTransfer is the queue type for transfer queue processor | ||
| QueueTypeTransfer | ||
| // QueueTypeTimer is the queue type for timer queue processor | ||
| QueueTypeTimer |
There was a problem hiding this comment.
These new enums overlap with existing ones above which is confusing. Do we still need them?
There was a problem hiding this comment.
The existing ones will be removed when history queue v1 is deprecated.
There was a problem hiding this comment.
Also updated the comments.
taylanisikdemir
approved these changes
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Set standby task to low priority in history queue v2
Why?
Bug fix. The task priority assigner assigns high priority to tasks from active queue, even if it's from a standby domain. There is no active queue in history queue v2, we should assign low priority to tasks from standby domains.
How did you test it?
unit tests
also verified in docstore-staging
Potential risks
Release notes
Documentation Changes