[shard-distributor] AssignShards method fills ownership of the shards #7114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3vilhamster
commented
Jul 30, 2025
|
|
||
| type ShardState struct { | ||
| ExecutorID string | ||
| Revision int64 |
There was a problem hiding this comment.
Probably, this could be extended with more field for ephemeral shards
jakobht
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
GetState and AssignShards methods now use shard ownership information that the shard assignment process could change.
Using this information, we can give a read-after-write guarantee, so that we won't have double assignments.
Process never entirely removes assignments, as we must assign all shards to the executor.
Note: rebalanceShards will fail if a conflict happens and will retry either by timer or because any other change will trigger redistribution.
Why?
AssignShards is the main process of the shard-distributor, and it must update shard ownership so it can be consumed with the GetShardOwner call.
How did you test it?
Unit tests
Potential risks
Release notes
Documentation Changes