Skip to content

[shard-distributor] Executor cleanup removes shard ownership information #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

[shard-distributor] Executor cleanup removes shard ownership information #7113

merged 1 commit into from
Jul 30, 2025
+190 −45

Conversation

3vilhamster
Copy link
Contributor

What changed?
Updated DeleteExecutors store method so that all shards assigned to executors that are being deleted unassigned from them.

Why?
To prevent stale ownership information

How did you test it?
Unit tests

Potential risks

Release notes

Documentation Changes

jakobht
jakobht approved these changes Jul 30, 2025
View reviewed changes
Copy link
Member

@jakobht jakobht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though we should be very careful on how we handle shard not found errors

@3vilhamster 3vilhamster enabled auto-merge (squash) July 30, 2025 13:22
@3vilhamster 3vilhamster merged commit 3166754 into cadence-workflow:master Jul 30, 2025
25 checks passed
@3vilhamster 3vilhamster deleted the shard-distributor-delete-executor-revmap branch July 30, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakobht jakobht jakobht approved these changes

@Shaddoll Shaddoll Awaiting requested review from Shaddoll Shaddoll is a code owner

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@taylanisikdemir taylanisikdemir Awaiting requested review from taylanisikdemir taylanisikdemir is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@3vilhamster @jakobht