Skip to content

Fix history task latency metric for timer queue v2 #7031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2025
Merged

Fix history task latency metric for timer queue v2 #7031

merged 1 commit into from
Jul 8, 2025

Conversation

Shaddoll
Copy link
Member

@Shaddoll Shaddoll commented Jul 7, 2025

What changed?

  • Fix history task latency metric for timer queue v2
  • Add enqueue to schedule latency metric for queue v1

Why?

  • Timer tasks in history queuev2 can be created earlier than schedule time, we need to adjust the initial submit time for those tasks
  • Add enqueue to schedule latency for queue v1 to compare the latency between v1 and v2

How did you test it?
unit tests, integration tests

Potential risks
history queue latency metric will be messed up

Release notes

Documentation Changes

@Shaddoll Shaddoll merged commit a013af2 into cadence-workflow:master Jul 8, 2025
42 checks passed
@Shaddoll Shaddoll deleted the timer branch July 8, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylanisikdemir taylanisikdemir taylanisikdemir approved these changes

@neil-xie neil-xie Awaiting requested review from neil-xie neil-xie is a code owner

@davidporter-id-au davidporter-id-au Awaiting requested review from davidporter-id-au davidporter-id-au is a code owner

@Groxx Groxx Awaiting requested review from Groxx Groxx is a code owner

@shijiesheng shijiesheng Awaiting requested review from shijiesheng shijiesheng is a code owner

@jakobht jakobht Awaiting requested review from jakobht jakobht is a code owner

@3vilhamster 3vilhamster Awaiting requested review from 3vilhamster 3vilhamster is a code owner

@sankari165 sankari165 Awaiting requested review from sankari165 sankari165 is a code owner

@dkrotx dkrotx Awaiting requested review from dkrotx dkrotx is a code owner

@demirkayaender demirkayaender Awaiting requested review from demirkayaender demirkayaender is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shaddoll @taylanisikdemir