[active-active] Update replication simulation #7003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shaddoll
reviewed
Jun 25, 2025
| name: test-domain-2 | ||
| activeClusters: | ||
| - cluster1 | ||
| activeClusterName: cluster0 |
There was a problem hiding this comment.
previously primary cluster name was used as active cluster name so both of these domains were active on cluster0. If @fimanishi 's intent was different then can be addressed in follow up PR.
Shaddoll
approved these changes
Jun 25, 2025
d910e5e
into
cadence-workflow:master
25 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Updating replication simulation to support active-active domains and their failovers.
Misc change:
EntityNotExistsErrorwhen there's no cluster selection policy for given workflow and handle it in active cluster manager.How did you test it?
Next steps
Frontend cluster redirection layer needs to be updated to lookup active cluster of given workflow. Currently this layer only checks the domain of the request. I need to update the template and policy implementation to plumb wf id and run id.