Unify history task query - part 5 - replication task queries #6761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65c5fdd to
a22d831
Compare
Shaddoll
commented
Mar 27, 2025
| @@ -92,3 +88,45 @@ func (e *historyEngineImpl) GetDLQReplicationMessages( | |||
|
|
|||
| return tasks, nil | |||
| } | |||
|
|
|||
| func convertToReplicationTask(taskInfo *types.ReplicationTaskInfo) (persistence.Task, error) { | |||
There was a problem hiding this comment.
the function is created here not in types package to avoid circular dependency.
cfd5e87 to
5a1969d
Compare
| @@ -112,5 +112,5 @@ func hydrateReplicationTask( | |||
| history.Find(info.NewRunBranchToken, constants.FirstEventID), | |||
| ) | |||
|
|
|||
| return hydrator.Hydrate(context.Background(), info) | |||
| return hydrator.Hydrate(context.Background(), task) | |||
There was a problem hiding this comment.
why do we even need info object in this func?
| @@ -173,7 +173,7 @@ func (m *MetricsEmitterImpl) determineReplicationLatency(remoteClusterName strin | |||
|
|
|||
| var replicationLatency time.Duration | |||
| if len(tasks) > 0 { | |||
| creationTime := time.Unix(0, tasks[0].CreationTime) | |||
| creationTime := tasks[0].GetVisibilityTimestamp() | |||
There was a problem hiding this comment.
just double checking, does GetVisibilityTimestamp() return CreationTime for replication tasks?
taylanisikdemir
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
To unify history task query
How did you test it?
unit tests, integration tests, dev2 tests (TBD)
Potential risks
Release notes
Documentation Changes