Replace lego with ACMEz #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # acmeclient.go # acmemanager.go # go.mod # go.sum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It works! We dropped about 250 indirect dependencies (but unfortunately, zap adds several) and more than 550 lines of code because we no longer have to resort to hacks to compensate for the underlying API. ACMEz has a much more flexible API and sane configuration. For example, it will try all enabled challenges instead of just the first one; this means if one challenge fails, the next one will be attempted automatically instead of us having to create a new order after re-configuring the client, which also reduces hits against rate-limited endpoints. Yay!
There's still some work to do -- mostly logging and DNS providers -- but that can come soon hereafter.
I also implemented custom resolver support while I was at it.
Closes #71.