Skip to content

cmd: remove {add,remove}-package and upgrade commands #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cmd: remove {add,remove}-package and upgrade commands #7011

wants to merge 2 commits into from

Conversation

mohammed90
Copy link
Member

First half of implementing the proposal #7010. The plugin code is not pushed yet.

Closes #7010

@mohammed90
cmd: remove {add,remove}-package and upgrade commands
aea4013 
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
@mohammed90 mohammed90 added the discussion 💬 The right solution needs to be found label May 10, 2025
@mohammed90
remove unused function
08aee56 
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
@ItsHarper
Copy link

When you publish the plugin, can you document that caddy upgrade does not upgrade plugins? (unless I'm wrong about that)

@mohammed90
Copy link
Member Author

mohammed90 commented Jul 21, 2025 •
edited
Loading

When you publish the plugin, can you document that caddy upgrade does not upgrade plugins? (unless I'm wrong about that)

It will upgrade the plugins. Why wouldn't it? It's the same code from Caddy, just ripped out. If my messaging led the confusion anywhere, point it and I'll correct it.

@ItsHarper
Copy link

Looking at the code and doing a test where I built Caddy with an outdated plugin and then ran the upgrade command led me to believe that the upgrade command only updates Caddy, but keeps the same plugin versions.

@mohammed90
Copy link
Member Author

Looking at the code and doing a test where I built Caddy with an outdated plugin and then ran the upgrade command led me to believe that the upgrade command only updates Caddy, but keeps the same plugin versions.

You're right. Sorry, I was confused and misremembered how the code works. Well, more reasons to not have this "feature" builtin 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
discussion 💬 The right solution needs to be found
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: remove {add,remove}-package and upgrade commands from core
2 participants
@mohammed90 @ItsHarper