Fix TrustedCACerts backwards compatibility #6889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
approved these changes
Mar 10, 2025
|
I'm working on getting us pointed to 2.9.1 master, so hopefully we can 🔪 the special branch once I'm done :') |
|
Okay, awesome! What I might do instead, to ensure you get the exact tree of commits you want, is to change the |
|
yeah that'd work! I can point us back to master after we fix our config |
mholt
pushed a commit
that referenced
this pull request
Mar 11, 2025
* add failing test * fix ca pool provisioning * remove unused param
|
@jjiang-stripe Perfect -- I just republished the |
|
amazing thank you! |
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
* add failing test * fix ca pool provisioning * remove unused param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm very late to the party, but I was in the process of bumping our Caddy dependency and noticed #5784 has a slight bug with the backwards compatibility of the now-deprecated
TrustedCACertsoption.The Caddyfile bit works fine because it converts it to a
CARaw, but if you specify the option directly via JSON, we don't end up populatingicp.poolsince we're not callingProvision()I wrote up a quick test to validate the behaviour with the additional call to
Provision()and also tested it on our instance of Caddy. It'd be nice to cherrypick this onto the 2.8.0+ releases (I'm specifically looking at 2.9.1) to make sure this option still works while it's deprecated! I plan to migrate us to the new config options, but our deploy process makes that a bit difficult to do simultaneously with the Caddy upgrade 😅