Skip to content

ci: allow using the toolchain Go "toolchain" #6846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2025

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Feb 17, 2025

This is the first step to allow setting the toolchain directive in go.mod. The patch also adds some missing build tags to speed up the builds.

@mohammed90
Copy link
Member

Since we now require 1.24 already, I wonder if we should drop the "last 2 versions" rule. I know this affects RHEL and CentOS because they tend to be 1 version behind.

@mholt
Copy link
Member

mholt commented Feb 28, 2025

Yep; I just updated repo settings to require only the latest Go version tests to pass.

And we should probably remove Go 1.23 from our CI.

@mholt mholt merged commit d2a2311 into caddyserver:master Mar 7, 2025
20 checks passed
@mholt
Copy link
Member

mholt commented Mar 7, 2025

Thanks Kevin!

@mholt mholt added the CI/CD 🔩 Automated tests, releases label Mar 7, 2025
@mholt mholt added this to the v2.10.0-beta.2 milestone Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants