Skip to content

ci: use commit sha in goreleaser-check #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 5, 2024
Merged

ci: use commit sha in goreleaser-check #6677

merged 4 commits into from
Nov 5, 2024

Conversation

mohammed90
Copy link
Member

No description provided.

@mohammed90
ci: use commit sha in goreleaser-check
8029303 
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
@mohammed90 mohammed90 added the CI/CD 🔩 Automated tests, releases label Nov 5, 2024
@mohammed90
fix output assignment
fdb5fc1 
Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
@mholt
Copy link
Member

mholt commented Nov 5, 2024

This is failing... should I wait to merge this until after the beta 3 release today?

@mohammed90
Copy link
Member Author

This is failing... should I wait to merge this until after the beta 3 release today?

For some reason, it still picks up sdk@0.21.0 despite our go.mod having 0.31. Can you try locally as sanity check?

TAG=master goreleaser build --snapshot. It's something like this.

@mohammed90
Copy link
Member Author

I have restricted it to either PRs from branches on this repo or on master because it's easier to deal with the Go modules flow. I see the checks are green. It'll probably also be green on master. This PR is ready.

@francislavoie francislavoie merged commit b285763 into master Nov 5, 2024
33 checks passed
@francislavoie francislavoie deleted the improve-goreleaser-check branch November 5, 2024 21:07
@BrewTestBot BrewTestBot mentioned this pull request Dec 31, 2024
Merged
1 task
mohammed90 added a commit to cedricziel/caddy that referenced this pull request Aug 29, 2025
@mohammed90
ci: use commit sha in goreleaser-check (caddyserver#6677)
b8b0df8 
* ci: use commit sha in goreleaser-check

Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>

* fix output assignment

Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>

* run only on non-fork or caddyserver repo, and use branch name

Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>

---------

Signed-off-by: Mohammed Al Sahaf <msaa1990@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie approved these changes

Assignees
No one assigned
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mohammed90 @mholt @francislavoie